Re: [scikit-image] Help with making moments nD

2017-04-07 Thread Juan Nunez-Iglesias
Hi Jaime, Thanks for an outrageously thorough response! Firstly, I totally missed that the dc and dr multipliers were in a different order! Looks like we will have to do some deprecation! Second, my own timings match yours, even for the 2D horse image. I’ve renamed my function moments_central_

Re: [scikit-image] Help with making moments nD

2017-04-07 Thread Jaime Fernández del Río
Hi Juan, The transposition is almost certainly due to the fact that in the Cython implementation the p loop, which loops rows of the moments array, uses the dc multiplier, which comes from the image columns, while the q loop, which loops columns of the moments array, uses the dr multiplier, which

[scikit-image] Help with making moments nD

2017-04-07 Thread Juan Nunez-Iglesias
Hi everyone, I’ve started work on getting image moments working in nD. I have two working alternative implementations: one with NumPy broadcasting and one with Numba JIT. Both are consistent with each other and with the existing Cython implementation, with to caveats: 1- my results are the *tr