Re: [scikit-learn] Code review

2016-06-20 Thread Joel Nothman
I think perhaps that FAQ should be updated to say "nag if needed"! Apologies for that delay, @olologin. Yes, it would be good if we had a better way of organising reviewing priorities, but between github's feature set and the distributed nature of the core dev team, we land up relying on chance, o

Re: [scikit-learn] Code review

2016-06-20 Thread Nelson Liu
The review process has always been quite slow; the only thing you can do is ping and try to fix things on your side as quickly as possible. There are a lot of PRs in development at any one time, and it's difficult for the reviewers (let alone the contributors, as you mentioned) to keep track of eve

[scikit-learn] Code review

2016-06-20 Thread olologin
Hi guys, I know scikit-learn may not be your main project, and you all are very busy at work so you don't have free time to review all pull requests, I understand it. Is there something project leaders can do to speed-up review process? Because I have bunch of pull requests which I made 5-7 mo