Re: [scikit-learn] Vote: Add Adrin Jalali to the scikit-learn technical committee

2020-04-28 Thread Joris Van den Bossche
+1 On Tue, 28 Apr 2020 at 01:34, Joel Nothman wrote: > +1 > > On Tue, 28 Apr 2020 at 02:23, Tom DLT wrote: > >> +1 >> >> Le lun. 27 avr. 2020, à 07 h 00, Alexandre Gramfort < >> alexandre.gramf...@inria.fr> a écrit : >> >>> +1 >>> ___ >>> scikit-learn

Re: [scikit-learn] VOTE: scikit-learn governance document

2019-02-19 Thread Joris Van den Bossche
And a +1 from me as well Op di 19 feb. 2019 11:47 schreef Joel Nothman Uhh... I forgot to vote. +1 :) > > It seems there's some consensus. > ___ > scikit-learn mailing list > scikit-learn@python.org > https://mail.python.org/mailman/listinfo/scikit-lear

Re: [scikit-learn] benchmarking TargetEncoder Was: ANN Dirty_cat: learning on dirty categories

2018-12-15 Thread Joris Van den Bossche
Op vr 14 dec. 2018 om 16:46 schreef Andreas Mueller : > As far as I understand, the open PR is not a leave-one-out TargetEncoder? > > I would want it to be :-/ > > I also did not yet add the CountFeaturizer from that scikit-learn PR, > because it is actually quite different (e.g it doesn't work fo

Re: [scikit-learn] benchmarking TargetEncoder Was: ANN Dirty_cat: learning on dirty categories

2018-12-13 Thread Joris Van den Bossche
Hi all, I finally had some time to start looking at it the last days. Some preliminary work can be found here: https://github.com/jorisvandenbossche/target-encoder-benchmarks. Up to now, I only did some preliminary work to set up the benchmarks (based on Patricio Cerda's code, https://arxiv.org/p

Re: [scikit-learn] make all new parameters keyword-only?

2018-11-20 Thread Joris Van den Bossche
Op zo 18 nov. 2018 om 11:14 schreef Joel Nothman : > I think we're all agreed that this change would be a good thing. > > What we're not agreed on is how much risk we take by breaking legacy code > that relied on argument order. > I think that, in principle, it could be possible to do this with a

Re: [scikit-learn] New core dev: Joris Van den Bossche

2018-06-26 Thread Joris Van den Bossche
Thanks all! I have been really enjoying working with the scikit-learn community! Joris 2018-06-26 17:36 GMT+02:00 Andreas Mueller : > Welcome on board Joris, and thank you for all your work so far! > > > On 06/23/2018 06:42 AM, Olivier Grisel wrote: > > Hi everyone! > >

Re: [scikit-learn] scikit-learn-contrib: building Cython, cpp files

2018-05-31 Thread Joris Van den Bossche
Hi Dylan, In case you are still looking for a solution:I didn't directly find good templates for packages that depend on cython (there are quite some, but from quickly looking at them, I didn't find a simple one), but you can maybe have a look at one of the other scikit-learn-contrib packages that

Re: [scikit-learn] New Transformer to Support Multiple Column Pipelines & One Hot Encoding

2018-02-20 Thread Joris Van den Bossche
Hi Dale, Those two issues you mention are indeed current bottlenecks of sklearn's API, but we are currently working on trying to solve them: 1) ColumnTransformer to be able to apply different transformers to different columns: https://github.com/scikit-learn/scikit-learn/pull/9012/ 2) As you men