Re: [scikit-learn] Contribution - Markov Clustering

2017-07-11 Thread Uri Goren
I've added this PR, and I addressed in the comments some of your concerns (publications, comparison to affinity propagation, etc). https://github.com/scikit-learn/scikit-learn/pull/9329 I'd love for you to review, since this is my first PR in the scikit learn repository On Wed, Jul 12, 2017 at 1

Re: [scikit-learn] Contribution - Markov Clustering

2017-07-11 Thread Olivier Grisel
If this is the first time you contribute, please make sure to carefully read the contributors guide till the end: http://scikit-learn.org/stable/developers/contributing.html In particular, make sure to follow the estimators API conventions for your PR to get a chance to be reviewed. In particular

Re: [scikit-learn] Contribution - Markov Clustering

2017-07-11 Thread Jacob Schreiber
You don't need our permission to submit a PR, go ahead! We welcome PRs. On Mon, Jul 10, 2017 at 9:36 PM, Uri Goren wrote: > I have, > The only criterion that I am unsure about is the number citations. > > In the literature Markov clustering is usually compared to affinity > prolongation, which a

Re: [scikit-learn] Contribution - Markov Clustering

2017-07-10 Thread Uri Goren
I have, The only criterion that I am unsure about is the number citations. In the literature Markov clustering is usually compared to affinity prolongation, which also has a similar number of citations. I have attached my implementation in my github account for you to review. Do I have your appr

Re: [scikit-learn] Contribution - Markov Clustering

2017-07-10 Thread Alexandre Gramfort
hi, did you have a look at : http://scikit-learn.org/stable/faq.html#what-are-the-inclusion-criteria-for-new-algorithms Alex ___ scikit-learn mailing list scikit-learn@python.org https://mail.python.org/mailman/listinfo/scikit-learn

[scikit-learn] Contribution - Markov Clustering

2017-07-10 Thread Uri Goren
Hi, I've been advised to contact you before working on an implementation of a new feature. I am thinking of implementing the Markov clustering and add it to sklearn.cluster module. See: https://micans.org/mcl/ https://gist.github.com/urigoren/1f76567f3af56ed8c33f076537768a60 Do you know if anyo