Re: [scikit-learn] Typo in online documentation on Matrix Factorization

2017-07-06 Thread Olivier Grisel
I think the documentation is correct. U, a.k.a. "the code" or "the activations" has shape (n_samples, n_components) and V a.k.a. "the dictionary" or "the components" has shape (n_components, n_features) in both case. We could use n_components uniformly instead of n_atoms for consistency's sake (an

Re: [scikit-learn] Typo in online documentation on Matrix Factorization

2017-07-06 Thread Olivier Grisel
2017-07-06 15:10 GMT+02:00 Olivier Grisel : > (and just make sure that the "components" is a synonym for "dictionary > atoms" in the literature). Actually I meant: and just make sure that our documentation states explicitly that the "components" is a synonym for "dictionary atoms" in the literatu

[scikit-learn] Typo in online documentation on Matrix Factorization

2017-07-06 Thread axel breuer via scikit-learn
Hi, First at all, I would like to warmly thank the scikit developer community with providing us with such a high quality ML library: it really became an amazing piece of scientific software. I have a comment concerning the online documentation on Matrix Factorization Problems. (I use this mailin