Re: [scikit-learn] check_estimator and score_samples method

2018-12-13 Thread Jason Rudy
Thanks, Joel. From your response I assume that the use of a y argument to score_samples is not a violation of the sklearn API, so I'll keep the method and find a workaround for the check_estimator test as it's currently written. I'll comment on the issue as well. On Mon, Dec 10, 2018 at 2:58

Re: [scikit-learn] check_estimator and score_samples method

2018-12-10 Thread Joel Nothman
We're trying to make check_estimator more flexible ( https://github.com/scikit-learn/scikit-learn/pull/8022) but this is certainly not something we had considered yet. Perhaps suggest it there? Or for now we could just make the check pass if score_samples yields a TypeError with only X...

[scikit-learn] check_estimator and score_samples method

2018-12-08 Thread Jason Rudy
Hi all, I'm working on updating py-earth for some recent changes in scikit-learn and cython. It seems like check_estimator has been significantly improved, and I'm working through making py-earth compliant with it. I've hit the following issue, though. It seems check_estimator tests