Re: [scikit-learn] Question about contributing to scikit-learn
Hi Parker, We strongly urge new contributors to start with small issues (documentation, small fixes, etc.) to gain confidence in the contribution procedure, etc. Once you've worked on small issues and understand better what comes through the issue tracker, you can consider bigger contributions. We have indeed proposed support for imblearn-like Pipeline extensions ( https://github.com/scikit-learn/scikit-learn/issues/3855#issuecomment-357949997). And yes, we're in need of a contributor there, but I would rather review and merge smaller pieces of your work, before finding a large one that needs a lot of changes before merge. Joel On Wed, 5 Dec 2018 at 12:15, parker x wrote: > Dear scikit-learn developers, > > My name is Parker, and I'm a data scientist. > > Scikit-learn is a great ML library that I work frequently for work and > personal projects. I have always wanted to contribute something to the > scikit-learn community, and I am wondering if you could give some opinions > on following two ideas for contribution. > > My first idea is to integrate another python library 'imbalanced-learn' > into scikit-learn so that people could also use scikit-learn to deal with > imbalance issues. > > Another idea is to combine those scikit-learn built-in feature selection > functions into one automated feature selection function that might benefit > those users who are not familiar with feature selection process. > > Looking forward to your suggestions! And thank you very much for your time! > > Best, > Parker > ___ > scikit-learn mailing list > scikit-learn@python.org > https://mail.python.org/mailman/listinfo/scikit-learn > ___ scikit-learn mailing list scikit-learn@python.org https://mail.python.org/mailman/listinfo/scikit-learn
Re: [scikit-learn] New core dev: Adrin Jalali
Indeed, welcome Adrin, and thanks a lot for your investment on the package! Gaël On Sat, Dec 08, 2018 at 09:26:15AM -0500, Andreas Mueller wrote: > Congratulations and welcome Adrin! > On 12/5/18 5:32 PM, Joel Nothman wrote: > The Scikit-learn core development team has welcomed a new member, Adrin > Jalali, who has been doing some really amazing work in contributing code > and reviews since July (aside from occasional contributions since 2014). > Congratulations and welcome, Adrin! > ___ > scikit-learn mailing list > scikit-learn@python.org > https://mail.python.org/mailman/listinfo/scikit-learn > ___ > scikit-learn mailing list > scikit-learn@python.org > https://mail.python.org/mailman/listinfo/scikit-learn -- Gael Varoquaux Senior Researcher, INRIA Parietal NeuroSpin/CEA Saclay , Bat 145, 91191 Gif-sur-Yvette France Phone: ++ 33-1-69-08-79-68 http://gael-varoquaux.infohttp://twitter.com/GaelVaroquaux ___ scikit-learn mailing list scikit-learn@python.org https://mail.python.org/mailman/listinfo/scikit-learn
[scikit-learn] check_estimator and score_samples method
Hi all, I'm working on updating py-earth for some recent changes in scikit-learn and cython. It seems like check_estimator has been significantly improved, and I'm working through making py-earth compliant with it. I've hit the following issue, though. It seems check_estimator tests score_samples using only X as an argument, and py-earth's score_samples requires y as well. So, my question is: must score_samples work with just X (and therefore maybe I should just remove it from py-earth) or is it okay to have a score_samples that requires y, and I should try to find a workaround for check_estimator? Best, Jason ___ scikit-learn mailing list scikit-learn@python.org https://mail.python.org/mailman/listinfo/scikit-learn
Re: [scikit-learn] New core dev: Adrin Jalali
Congratulations and welcome Adrin! On 12/5/18 5:32 PM, Joel Nothman wrote: The Scikit-learn core development team has welcomed a new member, Adrin Jalali, who has been doing some really amazing work in contributing code and reviews since July (aside from occasional contributions since 2014). Congratulations and welcome, Adrin! ___ scikit-learn mailing list scikit-learn@python.org https://mail.python.org/mailman/listinfo/scikit-learn ___ scikit-learn mailing list scikit-learn@python.org https://mail.python.org/mailman/listinfo/scikit-learn
Re: [scikit-learn] New core dev: Adrin Jalali
Welcome and thanks for contributing! Hanmin Qin - Original Message - From: Gael Varoquaux To: Scikit-learn mailing list Subject: Re: [scikit-learn] New core dev: Adrin Jalali Date: 2018-12-09 01:18 Indeed, welcome Adrin, and thanks a lot for your investment on the package! Gaël On Sat, Dec 08, 2018 at 09:26:15AM -0500, Andreas Mueller wrote: > Congratulations and welcome Adrin! > On 12/5/18 5:32 PM, Joel Nothman wrote: > The Scikit-learn core development team has welcomed a new member, Adrin > Jalali, who has been doing some really amazing work in contributing code > and reviews since July (aside from occasional contributions since 2014). > Congratulations and welcome, Adrin! > ___ > scikit-learn mailing list > scikit-learn@python.org > https://mail.python.org/mailman/listinfo/scikit-learn > ___ > scikit-learn mailing list > scikit-learn@python.org > https://mail.python.org/mailman/listinfo/scikit-learn -- Gael Varoquaux Senior Researcher, INRIA Parietal NeuroSpin/CEA Saclay , Bat 145, 91191 Gif-sur-Yvette France Phone: ++ 33-1-69-08-79-68 http://gael-varoquaux.infohttp://twitter.com/GaelVaroquaux ___ scikit-learn mailing list scikit-learn@python.org https://mail.python.org/mailman/listinfo/scikit-learn ___ scikit-learn mailing list scikit-learn@python.org https://mail.python.org/mailman/listinfo/scikit-learn
