[scikit-learn] Consultation: eligibility of inclusion of speed-up?

I need core devs opinion (please, only core devs, I am sending this on the public ML for transparency): The following PR adds a speed up for expansion of polynomial kernels: https://github.com/scikit-learn/scikit-learn/pull/13003 According to the author, the speed up is significant (needs to be v

[scikit-learn] What's are the advantages and disadvantages of incremental learning?

Generally speaking, we all know it's to save spaces with incremental learning. According to the ques in stackoverflow , it also said that. But what's the disadvantages? What I

Re: [scikit-learn] Sprint discussion points?

I totally forgot to mention it before the sprint started but i'd like to have a discussion about the integration of a new benchmark suite into the scikit-learn organization. Essentially, I've been working on a benchmark suite for sklearn using the airspeed velocity (asv) framework. The purpose

Re: [scikit-learn] Consultation: eligibility of inclusion of speed-up?

To me the maintainability of the added code also plays a role, and this PR is really nice and short in its implementation. It needs better documentation (other than the plot_ file) to better demonstrate its benefits, otherwise looks reasonable to have it IMO. On Tue, Feb 26, 2019 at 11:11 AM Gael

Re: [scikit-learn] Sprint discussion points?

Was that the same that Vlad used? https://github.com/scikit-learn/scikit-learn-speed We might want to just replace that, given that it hasn't been touched in 7 years? On 2/26/19 5:22 AM, Jeremie du Boisberranger wrote: I totally forgot to mention it before the sprint started but i'd like to

Re: [scikit-learn] Sprint discussion points?

Not the same, although there are similarities. However asv provides tools to compare benchmarks across commits, and to publish them in html format to follow their evolution through time such as https://pv.github.io/numpy-bench/ Here's the link of the benchmark suite : https://github.com/jerem

Re: [scikit-learn] Sprint discussion points?

What do you think needs to be raised for discussion? On Tue., 26 Feb. 2019, 12:06 pm Jeremie du Boisberranger, < jeremie.du-boisberran...@inria.fr> wrote: > Not the same, although there are similarities. However asv provides > tools to compare benchmarks across commits, and to publish them in htm