Re: [scikit-learn] check_estimator and score_samples method

2018-12-10 Thread Joel Nothman
We're trying to make check_estimator more flexible ( https://github.com/scikit-learn/scikit-learn/pull/8022) but this is certainly not something we had considered yet. Perhaps suggest it there? Or for now we could just make the check pass if score_samples yields a TypeError with only X...

Re: [scikit-learn] Question about contributing to scikit-learn

2018-12-10 Thread parker x
Hi Emmanuel and Joel, Thanks very much for your advice. I will take a look at small issues first and see what to contribute from there. Best, Parker eamanu15 于2018年12月9日周日 上午6:17写道: > Hello Parker, > > I can tell you my experience. > > I start to contribute to sklearn two month ago, and I