Re: [scikit-learn] make all new parameters keyword-only?

2018-11-14 Thread Hanmin Qin
I agree that this feature is advantageous and I'm +1 to apply it to new classes/functions, but for existing classes/functions, does it seem strange that only certain arguments are keyword only (i.e., some arguments can be specified by position, while others can't)? Hanmin Qin

Re: [scikit-learn] Difference between CircleCI python2 and python3

2018-11-19 Thread Hanmin Qin
Thanks for the great PR.We're using matplotlib 3.0.1 (latest version) in python3 build and matplotlib 1.4.3 (minimal dependency) in python2 build.I think color="tab:blue" is not supported by matplotlib 1.X, so maybe you can try to use some simple colors. Hanmin Qin - O

Re: [scikit-learn] New core dev: Adrin Jalali

2018-12-08 Thread Hanmin Qin
Welcome and thanks for contributing! Hanmin Qin - Original Message - From: Gael Varoquaux To: Scikit-learn mailing list Subject: Re: [scikit-learn] New core dev: Adrin Jalali Date: 2018-12-09 01:18 Indeed, welcome Adrin, and thanks a lot for your investment on the package! Gaël On Sat

Re: [scikit-learn] ANN: Scikit-learn 0.20.2 released

2018-12-31 Thread Hanmin Qin
0.20.2 is now available on conda default channel. Happy new year to everyone! The scikit-learn developer team - Original Message - From: Joel Nothman To: Scikit-learn user and developer mailing list Subject: [scikit-learn] ANN: Scikit-learn 0.20.2 released Date: 2019-01-01 09:28 A bug fi

Re: [scikit-learn] Next Sprint

2019-01-08 Thread Hanmin Qin
Apologies I won't be available because of school work.Thanks the whole community for your great help. I'll continue to contribute and keep online during the sprint. Hanmin Qin - Original Message - From: Gael Varoquaux To: Scikit-learn mailing list Subject: Re: [scikit-l

Re: [scikit-learn] VOTE: scikit-learn governance document

2019-02-10 Thread Hanmin Qin
+1 (personally I still think it's better to keep the flow chart, it seems useful for beginners) Hanmin Qin - Original Message - From: Alexandre Gramfort To: Scikit-learn mailing list Subject: Re: [scikit-learn] VOTE: scikit-learn governance document Date: 2019-02-11 01:29 +1 for m

Re: [scikit-learn] Sprint discussion points?

2019-02-18 Thread Hanmin Qin
make the decision). Some bugs seems not trivial (e.g., #13142 related to BaseMixture and #13124 related to StratifiedKFold). Hanmin Qin - Original Message - From: Olivier Grisel To: Scikit-learn mailing list Subject: Re: [scikit-learn] Sprint discussion points? Date: 2019-02-15 23:06

Re: [scikit-learn] Sprint discussion points?

2019-02-21 Thread Hanmin Qin
, I don't think you need to consider my time. I'll comment on relevant issues if I have any thoughts. Hanmin Qin - Original Message - From: Joel Nothman To: Scikit-learn user and developer mailing list , Hanmin Qin Subject: Re: [scikit-learn] Sprint discussion points? Date:

[scikit-learn] API Discussion: Where shall we put the plotting functions?

2019-04-02 Thread Hanmin Qin
See https://github.com/scikit-learn/scikit-learn/issues/13448 We've introduced several plotting functions (e.g., plot_tree and plot_partial_dependence) and will introduce more (e.g., plot_decision_boundary) in the future. Consequently, we need to decide where to put these functions. Currently, t

Re: [scikit-learn] New core developers: thomasjpfan and nicolashug

2019-04-03 Thread Hanmin Qin
Congratulations and welcome to the team! Hanmin Qin - Original Message - From: Joel Nothman To: Scikit-learn user and developer mailing list Subject: [scikit-learn] New core developers: thomasjpfan and nicolashug Date: 2019-04-04 07:52 The core developers of Scikit-learn have recently

Re: [scikit-learn] Monthly meetings between core developers

2019-07-18 Thread Hanmin Qin
I don't think it's worthwhile to worry too much about Beijing time if I'm the only person in Beijing. I'm happy to get up early once a month to learn from the great team! Hanmin Qin - Original Message - From: Alexandre Gramfort To: Scikit-learn mailing list Subjec

Re: [scikit-learn] Vote on SLEP009: keyword only arguments

2019-09-11 Thread Hanmin Qin
I'll vote +1, though there're still lots of things to decide. Hanmin Qin - Original Message - From: Alexandre Gramfort To: Scikit-learn mailing list Subject: Re: [scikit-learn] Vote on SLEP009: keyword only arguments Date: 2019-09-12 03:43 > But overall I'm + 1 on

Re: [scikit-learn] Vote on SLEP010: n_features_in_ attribute

2019-12-03 Thread Hanmin Qin
+1 (seems that users are unhappy because we vote in the mailing list?) Hanmin Qin - Original Message - From: Gael Varoquaux To: Scikit-learn mailing list Subject: Re: [scikit-learn] Vote on SLEP010: n_features_in_ attribute Date: 2019-12-04 12:34 +1. Great job! Gaël On Tue, Dec 03

Re: [scikit-learn] Vote: Add Adrin Jalali to the scikit-learn technical committee

2020-04-27 Thread Hanmin Qin
+1 Hanmin Qin - Original Message - From: Jeremie du Boisberranger To: scikit-learn@python.org Subject: Re: [scikit-learn] Vote: Add Adrin Jalali to the scikit-learn technical committee Date: 2020-04-27 21:23 +1 On 27/04/2020 15:18, Nicolas Hug wrote: > +1 > > On 4/27/20 9:16