Re: [Scikit-learn-general] Suggestions for the model selection module

2016-05-07 Thread Matthias Feurer
Dear Joel, Thank you for taking the time to answer my email. I didn't see the PR on this topic, thanks for pointing me to that. I can see your points with regards to the get_params() method and it might be better if I write more serialization code on my side (although for example

Re: [Scikit-learn-general] Suggestions for the model selection module

2016-05-07 Thread Joel Nothman
On 7 May 2016 at 19:12, Matthias Feurer wrote: > 1. Return the fit and predict time in `grid_scores_` > This has been proposed for many years as part of an overhaul of grid_scores_. The latest attempt is currently underway at

[Scikit-learn-general] Suggestions for the model selection module

2016-05-07 Thread Matthias Feurer
Dear scikit-learn team, First of all, the model selection module is really easy to use and has a nice and clean interface, I really like that. Nevertheless, while using it for benchmarks I found some shortcomings where I think the module could be improved. 1. Return the fit and predict time