Re: [Scikit-learn-general] Common testing suite

2012-06-07 Thread Andreas Mueller
On 06/07/2012 11:46 PM, Lars Buitinck wrote: > 2012/6/7 Andreas Mueller: >> Yeah. I recently read about that. Coming from C++ that feels weird, >> though in this situation it helps us :) > [OT] Come to think of it, this isn't as weird as it seems at first > when you compare it to C++'s pure virtual

Re: [Scikit-learn-general] Common testing suite

2012-06-07 Thread Lars Buitinck
2012/6/7 Andreas Mueller : > Yeah. I recently read about that. Coming from C++ that feels weird, > though in this situation it helps us :) [OT] Come to think of it, this isn't as weird as it seems at first when you compare it to C++'s pure virtual functions with implementation (http://www.gotw.ca/

Re: [Scikit-learn-general] Common testing suite

2012-06-07 Thread Andreas Mueller
On 06/07/2012 11:23 PM, Lars Buitinck wrote: > 2012/6/7 Andreas Mueller: >> - Some classes are "base classes" that should not be instantiated (like >> BaseLibSVM). >> But these classes are not really marked as such. Some classes are >> abstract base >> classes, but not all of them. For

Re: [Scikit-learn-general] Common testing suite

2012-06-07 Thread Lars Buitinck
2012/6/7 Andreas Mueller : > - Some classes are "base classes" that should not be instantiated (like > BaseLibSVM). >     But these classes are not really marked as such. Some classes are > abstract base >     classes, but not all of them. For example BaseLibSVM has no abstract > method. >     F

Re: [Scikit-learn-general] Common testing suite

2012-06-07 Thread Gael Varoquaux
On Thu, Jun 07, 2012 at 07:46:38PM +0200, Andreas Mueller wrote: > Too bad you're unavailable but I'm sure someone else can spare some time. I am back on the 20nd! G -- Live Security Virtual Conference Exclusive live eve

Re: [Scikit-learn-general] Common testing suite

2012-06-07 Thread Andreas Mueller
On 06/07/2012 07:43 PM, Gael Varoquaux wrote: > On Thu, Jun 07, 2012 at 07:12:53PM +0200, Andreas Mueller wrote: >> As I said, any feedback would be very welcome! > I am about to leave for China and terribly late on the things that I > should get done before I leaving, so I won't give much feedback

Re: [Scikit-learn-general] Common testing suite

2012-06-07 Thread Gael Varoquaux
On Thu, Jun 07, 2012 at 07:12:53PM +0200, Andreas Mueller wrote: > As I said, any feedback would be very welcome! I am about to leave for China and terribly late on the things that I should get done before I leaving, so I won't give much feedback, other than that I think that it's a great idea. I

[Scikit-learn-general] Common testing suite

2012-06-07 Thread Andreas Mueller
Hi everybody. I just started a PR on common testing and would really like your feedback: https://github.com/scikit-learn/scikit-learn/pull/893 The idea is to get all estimators in sklearn and do some testing based on the mixins. This is still in a very early stage and there are some problems whic