Re: [Scikit-learn-general] KMeans implementation in C with OpenMP

2012-01-05 Thread Fabian Pedregosa
On Thu, Jan 5, 2012 at 11:14 PM, Lars Buitinck wrote: > 2012/1/5 Fabian Pedregosa : >> Good look with the building issues. A safe solution would be to do >> conditional compilation. Scipy does it and we use the same build >> system, unfortunately it's not as easy as it sounds :-). > > I hope you m

Re: [Scikit-learn-general] KMeans implementation in C with OpenMP

2012-01-05 Thread Lars Buitinck
2012/1/5 Fabian Pedregosa : > Good look with the building issues. A safe solution would be to do > conditional compilation. Scipy does it and we use the same build > system, unfortunately it's not as easy as it sounds :-). I hope you mean just passing compiler options optionally; you don't need co

Re: [Scikit-learn-general] KMeans implementation in C with OpenMP

2012-01-05 Thread Fabian Pedregosa
On Thu, Jan 5, 2012 at 9:35 AM, Benjamin Hepp wrote: > My implementation is assuming all data fits in memory. I'll do some > benchmarks and look into the openmp/building/cython issues. Hey, Good look with the building issues. A safe solution would be to do conditional compilation. Scipy does it

Re: [Scikit-learn-general] KMeans implementation in C with OpenMP

2012-01-05 Thread Benjamin Hepp
My implementation is assuming all data fits in memory. I'll do some benchmarks and look into the openmp/building/cython issues. Benni On 12/23/11 10:46 PM, Gael Varoquaux wrote: > On Fri, Dec 23, 2011 at 10:42:45PM +0100, Gael wrote: >> The reason that we have integrated openmp code in the scikit

Re: [Scikit-learn-general] KMeans implementation in C with OpenMP

2011-12-23 Thread Olivier Grisel
2011/12/23 Gael Varoquaux : > The reason that we have integrated openmp code in the scikit so far, is that > it does not seem that there is a reliable way of testing if a compiler > supports it with distutils. The danger is thus to break the build for certain > evironments. This is very true, w

Re: [Scikit-learn-general] KMeans implementation in C with OpenMP

2011-12-23 Thread Gael Varoquaux
On Fri, Dec 23, 2011 at 10:42:45PM +0100, Gael wrote: > The reason that we have integrated openmp code in the scikit so far, is I meant: that we have not integrated > that it does not seem that there is a reliable way of testing if a > compiler supports it with distutils. The danger is thus to

Re: [Scikit-learn-general] KMeans implementation in C with OpenMP

2011-12-23 Thread Gael Varoquaux
The reason that we have integrated openmp code in the scikit so far, is that it does not seem that there is a reliable way of testing if a compiler supports it with distutils. The danger is thus to break the build for certain evironments. Gael - Original message - > 2011/12/23 Benjamin

Re: [Scikit-learn-general] KMeans implementation in C with OpenMP

2011-12-23 Thread Olivier Grisel
2011/12/23 Benjamin Hepp : > Hi, > > I was wondering about the KMeans implementation in scikit-learn. From a > quick scan of the code I see that the main stuff is implemented in > Cython but it's spread in two different functions for the m- and the > e-step and the main loop is in python. I'm using

Re: [Scikit-learn-general] KMeans implementation in C with OpenMP

2011-12-23 Thread Kenneth C. Arnold
It may be relevant to note that Cython has recently gained some OpenMP support: http://docs.cython.org/src/userguide/parallelism.html -- I haven't tried it, but perhaps it could help improve the scikit-learn implementation. -Ken On Dec 23, 2011 7:31 AM, "Benjamin Hepp" wrote: > > Hi, > > I was

[Scikit-learn-general] KMeans implementation in C with OpenMP

2011-12-23 Thread Benjamin Hepp
Hi, I was wondering about the KMeans implementation in scikit-learn. From a quick scan of the code I see that the main stuff is implemented in Cython but it's spread in two different functions for the m- and the e-step and the main loop is in python. I'm using my own KMeans routine written as a Py