Re: [Scikit-learn-general] Sparse NMF

2014-06-25 Thread Vamsi Krishna Potluru
Vlad, if you are going to cite the Mazack paper, you should also look into the original paper by Kim and Park (2006) which proposes the sparse NMF model ( the one which is currently implemented by Scikit-learn). For the sparse NMF model by Hoyer (2004), some benchmarks can be found in my ICLR pape

Re: [Scikit-learn-general] Sparse NMF

2014-06-25 Thread Vlad Niculae
Vamsi, do you have any benchmarks for your implementation? The biggest reason why we didn't change the current implementation yet is that it was hard to find something else that is consistently faster & better. Here are some benchmarks I did last time I looked at this, when I wanted to replace the

Re: [Scikit-learn-general] Sparse NMF

2014-06-25 Thread Michael Eickenberg
i will never post a docstring again :) sorry for the noise michael On Wednesday, June 25, 2014, Vlad Niculae wrote: > Hi, > > Allow me to clarify. We don't implement Hoyer's sparse update rule > indeed (it shouldn't say "this implements", I initially cited Hoyer > for motivating sparseness cons

Re: [Scikit-learn-general] Sparse NMF

2014-06-25 Thread Vlad Niculae
Hi, Allow me to clarify. We don't implement Hoyer's sparse update rule indeed (it shouldn't say "this implements", I initially cited Hoyer for motivating sparseness constraints in NMF). Instead, we implement a version of sparse NMF with a clear (but not particularly elegant) objective function, fo

Re: [Scikit-learn-general] Sparse NMF

2014-06-25 Thread Vamsi Krishna Potluru
Don't believe all you read :-). It says that but implements something else. ~Vamsi. On Wed, Jun 25, 2014 at 10:48 AM, Michael Eickenberg < michael.eickenb...@gmail.com> wrote: > https://github.com/scikit-learn/scikit-learn/blob/master/sklearn/decomposition/nmf.py#L346 > > References > -

Re: [Scikit-learn-general] Sparse NMF

2014-06-25 Thread Michael Eickenberg
https://github.com/scikit-learn/scikit-learn/blob/master/sklearn/decomposition/nmf.py#L346 References -- This implements C.-J. Lin. Projected gradient methods for non-negative matrix factorization. Neural Computation, 19(2007), 2756-2779. http://www.csie.ntu.ed

Re: [Scikit-learn-general] Sparse NMF

2014-06-25 Thread Vamsi Krishna Potluru
Yes, thats a different sparse model than the one in Hoyer, 2004 (most likely the one by Kim and Park). Maybe, Vlad or someone else can comment on that. ~Vamsi. On Wed, Jun 25, 2014 at 10:15 AM, Alexandre Gramfort < alexandre.gramf...@telecom-paristech.fr> wrote: > hi, > > have you played with t

Re: [Scikit-learn-general] Sparse NMF

2014-06-25 Thread Alexandre Gramfort
hi, have you played with the sparseness parameter of the NMF estimator? Alex On Wed, Jun 25, 2014 at 3:42 PM, Vamsi Krishna Potluru wrote: > Hello, > > I have worked a bit on the sparse NMF model proposed by Hoyer [1]. The > paper is mentioned in the Scikits NMF module but AFAIK the model is

[Scikit-learn-general] Sparse NMF

2014-06-25 Thread Vamsi Krishna Potluru
Hello, I have worked a bit on the sparse NMF model proposed by Hoyer [1]. The paper is mentioned in the Scikits NMF module but AFAIK the model is currently not implemented. Recently, we proposed an efficient algorithm based on block coordinate descent [2]. A reference python implementation is ava