Re: [Scikit-learn-general] estimator capability

2012-01-16 Thread Olivier Grisel
2012/1/16 Mathieu Blondel : > On Mon, Jan 16, 2012 at 10:29 PM, Olivier Grisel > wrote: > >> +1 for going on with the merge of ndarray / sparse matrix implementations. > > +1. When you have abstract code that is representation-independent, > being able to use the same estimator transparently is a

Re: [Scikit-learn-general] estimator capability

2012-01-16 Thread Mathieu Blondel
On Mon, Jan 16, 2012 at 10:29 PM, Olivier Grisel wrote: > +1 for going on with the merge of ndarray / sparse matrix implementations. +1. When you have abstract code that is representation-independent, being able to use the same estimator transparently is a real comfort. > However that won't sol

Re: [Scikit-learn-general] estimator capability

2012-01-16 Thread Olivier Grisel
2012/1/16 Lars Buitinck : > 2012/1/16 Mathieu Blondel : >> I wrote a class which takes a base estimator in its constructor. For >> efficiency reasons, it is best if the estimator supports dense input. >> I would like thus to issue a warning if the given estimator supports >> only sparse input (as i

Re: [Scikit-learn-general] estimator capability

2012-01-16 Thread Lars Buitinck
2012/1/16 Mathieu Blondel : > I wrote a class which takes a base estimator in its constructor. For > efficiency reasons, it is best if the estimator supports dense input. > I would like thus to issue a warning if the given estimator supports > only sparse input (as is the case of e.g. svm.sparse.Li

Re: [Scikit-learn-general] estimator capability

2012-01-16 Thread Mathieu Blondel
On Mon, Jan 16, 2012 at 9:46 PM, Olivier Grisel wrote: > Since we dropped python 2.5 support I think we could use an > @accept_input class decorators to make this kind of static > declarations more syntactically pleasing. Excellent idea! Mathieu -

Re: [Scikit-learn-general] estimator capability

2012-01-16 Thread Olivier Grisel
Since we dropped python 2.5 support I think we could use an @accept_input class decorators to make this kind of static declarations more syntactically pleasing. -- RSA(R) Conference 2012 Mar 27 - Feb 2 Save $400 by Jan. 27

[Scikit-learn-general] estimator capability

2012-01-16 Thread Mathieu Blondel
Hello everyone, I wrote a class which takes a base estimator in its constructor. For efficiency reasons, it is best if the estimator supports dense input. I would like thus to issue a warning if the given estimator supports only sparse input (as is the case of e.g. svm.sparse.LinearSVC). This rais