Re: [Scikit-learn-general] modified scikit-learn code

2013-02-03 Thread Alexandre Gramfort
as I said on the PR discussion. The gensim implementation does a for loop to avoid a copy of X basically it avoids this line: args = [X[safe_mask(X, y == k)] for k in np.unique(y)] the good approach would be cython but since our implementation works for sparse data it's more work ... Alex

Re: [Scikit-learn-general] modified scikit-learn code

2013-02-03 Thread Olivier Grisel
I opened an issue in the tracker for this: https://github.com/scikit-learn/scikit-learn/issues/1651 Any taker? -- Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Li

Re: [Scikit-learn-general] modified scikit-learn code

2013-02-02 Thread Andreas Mueller
On 02/02/2013 01:53 PM, Radim Rehurek wrote: Hello scikitters, I received a pull request with some modified scikit-learn code inside: https://github.com/piskvorky/gensim/blob/a73c84e21aecd3cc77ba2d752912f73b712bc60a/gensim/models/selectkbest.py Since I'm not familiar with the scikit-learn cod

[Scikit-learn-general] modified scikit-learn code

2013-02-02 Thread Radim Rehurek
Hello scikitters, I received a pull request with some modified scikit-learn code inside:  https://github.com/piskvorky/gensim/blob/a73c84e21aecd3cc77ba2d752912f73b712 bc60a/gensim/models/selectkbest.py Since I'm not familiar with the scikit-learn code base, can someone please tell me whe