Re: [Scikit-learn-general] "Need Review" tag

2015-12-04 Thread Manoj Kumar
+1. We can easily filter using those. We can also add "Need 2nd review" if needed. On Tue, Dec 1, 2015 at 11:24 PM, Joel Nothman wrote: > Labels weren't available for PRs until relatively recently. I think the > status and its meaning would be clearer with such tags. >

Re: [Scikit-learn-general] "Need Review" tag

2015-12-01 Thread Gael Varoquaux
> How about adding a "Need Review(s?)(er?)" tag?  For me, it's the '[MRG]' in the PR name. -- Go from Idea to Many App Stores Faster with Intel(R) XDK Give your users amazing mobile app experiences with Intel(R) XDK. Use

Re: [Scikit-learn-general] "Need Review" tag

2015-12-01 Thread Andreas Mueller
Yeah that was the intention of [MRG]. Though it might be easier to filter by tag. No strong opinion though. On 12/02/2015 12:44 AM, Gael Varoquaux wrote: >> How about adding a "Need Review(s?)(er?)" tag? > For me, it's the '[MRG]' in the PR name. > >

Re: [Scikit-learn-general] "Need Review" tag

2015-12-01 Thread Joel Nothman
Labels weren't available for PRs until relatively recently. I think the status and its meaning would be clearer with such tags. On 2 December 2015 at 15:16, Andreas Mueller wrote: > Yeah that was the intention of [MRG]. Though it might be easier to > filter by tag. > No strong

[Scikit-learn-general] "Need Review" tag

2015-12-01 Thread Raghav R V
How about adding a "Need Review(s?)(er?)" tag? (So we can add that to completed PRs and forget about reminding the reviewers?) ;) R -- Go from Idea to Many App Stores Faster with Intel(R) XDK Give your users amazing