Re: [scikit-learn] Question about contributing to scikit-learn

2018-12-08 Thread Joel Nothman
Hi Parker, We strongly urge new contributors to start with small issues (documentation, small fixes, etc.) to gain confidence in the contribution procedure, etc. Once you've worked on small issues and understand better what comes through the issue tracker, you can consider bigger contributions.

Re: [scikit-learn] New core dev: Adrin Jalali

2018-12-08 Thread Gael Varoquaux
Indeed, welcome Adrin, and thanks a lot for your investment on the package! Gaël On Sat, Dec 08, 2018 at 09:26:15AM -0500, Andreas Mueller wrote: > Congratulations and welcome Adrin! > On 12/5/18 5:32 PM, Joel Nothman wrote: > The Scikit-learn core development team has welcomed a new

[scikit-learn] check_estimator and score_samples method

2018-12-08 Thread Jason Rudy
Hi all, I'm working on updating py-earth for some recent changes in scikit-learn and cython. It seems like check_estimator has been significantly improved, and I'm working through making py-earth compliant with it. I've hit the following issue, though. It seems check_estimator tests

Re: [scikit-learn] New core dev: Adrin Jalali

2018-12-08 Thread Andreas Mueller
Congratulations and welcome Adrin! On 12/5/18 5:32 PM, Joel Nothman wrote: The Scikit-learn core development team has welcomed a new member, Adrin Jalali, who has been doing some really amazing work in contributing code and reviews since July (aside from occasional contributions since 2014).

Re: [scikit-learn] New core dev: Adrin Jalali

2018-12-08 Thread Hanmin Qin
Welcome and thanks for contributing! Hanmin Qin - Original Message - From: Gael Varoquaux To: Scikit-learn mailing list Subject: Re: [scikit-learn] New core dev: Adrin Jalali Date: 2018-12-09 01:18 Indeed, welcome Adrin, and thanks a lot for your investment on the package! Gaël On Sat,