Re: Re: Re: mercurial provider patch

2007-05-23 Thread Emmanuel Venisse
Ryan Daum a écrit : I have a local version here which now passes all Tck tests by doing the inventory of the repository after the tag. Emmanuel, I can provide you with a patch, but can you give me advice on how to get Subversion to produce a diff file (from svn diff) that will do the right

Re: Re: Re: mercurial provider patch

2007-05-23 Thread Emmanuel Venisse
If I remember it correctly, the constructor without the files list is to add scm errors with providers messages... Maybe we must add more javadoc on this class or deprecate this constructor, but a result in success must have the list of tagged files. Emmanuel Ryan Daum a écrit : Just want to p

Re: Re: mercurial provider patch

2007-05-22 Thread Ryan Daum
Just want to point out one more thing, and that is that the class TagScmResult has two constructors, one of which accepts the list of tagged files and the other which does not, leaving that list null. If the intention is that all SCM providers provide this list, then the other constructor should

Re: Re: mercurial provider patch

2007-05-22 Thread Ryan Daum
No, it's not possible to do this -- and in any case the list of tagged files would be the entire repository; not sure it makes sense that the Tck test should require that a provider return a list like this in this case. I'm very skeptical of making the provider's tag command perform an additional

Re: Re: mercurial provider patch

2007-05-22 Thread Emmanuel Venisse
It doesn't tag arbitrary files but it test the TagScmResult that must contains the list of tagged files. I'm sure you can know with the hg tag command the list of tagged files by parsing the output. Emmanuel Ryan Daum a écrit : What is the expected behaviour for this test given that many SCM