Re: [Scons-dev] tools and testing

2017-06-06 Thread William Blevins
Ah, right. The PR didn't show the commit for some reason. https://bitbucket.org/scons/scons/commits/0ba0c0371c240ef6bf302e4a6ec21b9e8d487dbe?at=default On Tue, Jun 6, 2017 at 11:43 AM, Russel Winder wrote: > On Fri, 2017-04-21 at 18:55 -0400, William Blevins wrote: >>

Re: [Scons-dev] tools and testing

2017-06-06 Thread Russel Winder
On Fri, 2017-04-21 at 18:55 -0400, William Blevins wrote: > Bill/Russel, > > I explicitly resolved Issue 1924 with PR 304. There doesn't seem to be a test in test/D/Issues/1924 to check for no regressions, did the test go elsewhere? > http://scons.tigris.org/issues/show_bug.cgi?id=1924 >

Re: [Scons-dev] tools and testing

2017-04-21 Thread William Blevins
It might be. I submitted a fix for 1924 as PR 304. That should have been merged... On Apr 21, 2017 2:17 PM, "Bill Deegan" wrote: :) Sounds good. On Fri, Apr 21, 2017 at 10:17 AM, Russel Winder wrote: > On Fri, 2017-04-21 at 09:36 -0700, Bill

Re: [Scons-dev] tools and testing

2017-04-21 Thread Bill Deegan
:) Sounds good. On Fri, Apr 21, 2017 at 10:17 AM, Russel Winder wrote: > On Fri, 2017-04-21 at 09:36 -0700, Bill Deegan wrote: > > Is this bug resolved? > > > > http://scons.tigris.org/issues/show_bug.cgi?id=2993 > > > > > > I suspect not given the name of the reporter.

Re: [Scons-dev] tools and testing

2017-04-21 Thread Russel Winder
On Fri, 2017-04-21 at 09:36 -0700, Bill Deegan wrote: > Is this bug resolved? > > http://scons.tigris.org/issues/show_bug.cgi?id=2993 > > I suspect not given the name of the reporter. :-) I'd have to spend a bit of time properly researching the report, creating a test, and then putting a

Re: [Scons-dev] tools and testing

2017-04-21 Thread Bill Deegan
Is this bug resolved? http://scons.tigris.org/issues/show_bug.cgi?id=2993 On Fri, Apr 21, 2017 at 2:29 AM, Russel Winder wrote: > On Wed, 2017-04-19 at 10:34 -0700, Bill Deegan wrote: > > Plenty of existing end to end tests function with mocked out external > > tools. >

Re: [Scons-dev] tools and testing

2017-04-21 Thread Russel Winder
On Wed, 2017-04-19 at 10:34 -0700, Bill Deegan wrote: > Plenty of existing end to end tests function with mocked out external > tools. > Any reason this can't be done for your pull request? The current pull request doesn't need such a thing as it doesn't include the dub tool. I believe the tests

Re: [Scons-dev] tools and testing

2017-04-19 Thread Bill Deegan
Plenty of existing end to end tests function with mocked out external tools. Any reason this can't be done for your pull request? On Tue, Apr 18, 2017 at 10:18 PM, Russel Winder wrote: > On Tue, 2017-04-18 at 20:48 -0700, Bill Deegan wrote: > > Would it be possible to mock

Re: [Scons-dev] tools and testing

2017-04-18 Thread Russel Winder
On Tue, 2017-04-18 at 20:48 -0700, Bill Deegan wrote: > Would it be possible to mock the dub tool for a unit test? > (Or even for a E2E test?) I had sort of arrived at having to do that anyway to avoid the need for the dub program on the test server. I think we have to assume the Dub tool always

Re: [Scons-dev] tools and testing

2017-04-18 Thread Bill Deegan
Would it be possible to mock the dub tool for a unit test? (Or even for a E2E test?) On Tue, Apr 18, 2017 at 8:13 PM, Russel Winder wrote: > On Tue, 2017-04-18 at 09:24 -0700, Bill Deegan wrote: > > Unitesting is there to make sure that no unintention breakage occurs. > >

Re: [Scons-dev] tools and testing

2017-04-18 Thread Bill Deegan
Unitesting is there to make sure that no unintention breakage occurs. I'm not willing to take a major piece of code into SCons core without tests. That would violate SCons's practices. -Bill On Tue, Apr 18, 2017 at 1:17 AM, Russel Winder wrote: > On Mon, 2017-04-17 at