Re: [Scons-dev] Fw: Re: [Scons-users] Glob() exclude doesn't match when used inside VariantDir

2015-09-24 Thread Florian Miedniak 
Great to see the fix being merged upstream within a week! One question
left: Shall I leave the tigris issue in state RESOLVED:FIXED with target
milestone UNSPECIFIED? Or shall I set target milestone to 2.x (and leaving
it open)? What is the recommended way to ensure that solved tickets like
this get closed on (next) release?

-Florian

2015-09-24 8:47 GMT+02:00 Florian Miedniak :

>
>
> *Gesendet:* Dienstag, 22. September 2015 um 12:43 Uhr
> *Von:* "Florian Miedniak" 
> *An:* scons-dev@scons.org
> *Betreff:* [Scons-dev] Fw: Re: [Scons-users] Glob() exclude doesn't match
> when used inside VariantDir
> Posted, just to preserve the thread history from scons-user list.
>
> *Gesendet:* Dienstag, 22. September 2015 um 12:00 Uhr
> *Von:* "William L Blevins" 
> *An:* "SCons users mailing list" 
> *Betreff:* Re: [Scons-users] Glob() exclude doesn't match when used
> inside VariantDir
>
> I would argue it's more for the developer list now.
>
> V/R,
> William
>
>
> On September 22, 2015, at 10:39 AM, Florian Miedniak <
> florian.miedn...@web.de> wrote:
>
>
> Hi Bill,
>
> I just created a pull request for the issue:
> https://bitbucket.org/scons/scons/pull-requests/252/fixed-3011-glob-called-with-exclude-didnt/diff
>
> Notes:
> - Is it okay to discuss this further on scons-user?
> - [offtopic] I just did a python bootstrap.py and was overwhelmed how
> simply it is to "build" SCons! The people maintaining our development
> environment just couldn't believe getting a rpm with a local scons build
> including my changes for deployment ...
>
> -Florian
>
> *Gesendet:* Donnerstag, 17. September 2015 um 15:24 Uhr
> *Von:* "Bill Deegan" 
> *An:* "SCons users mailing list" 
> *Betreff:* Re: [Scons-users] Glob() exclude doesn't match when used
> inside VariantDir
> Thanks!
> -Bill
>
> On Thu, Sep 17, 2015 at 3:40 AM, Florian Miedniak  > wrote:
>>
>> Hi Bill,
>>
>> I just created an issue in bug tracker (#3011) and will provide a pull
>> request as you suggested for further discussion.
>>
>> -Florian
>>
>> *Gesendet:* Mittwoch, 16. September 2015 um 16:46 Uhr
>> *Von:* "Bill Deegan" 
>> *An:* "SCons users mailing list" 
>> *Betreff:* Re: [Scons-users] Glob() exclude doesn't match when used
>> inside VariantDir
>> Florian,
>>
>> Good catch on the bug still being open. I've closed it. (It should have
>> been as the feature is (in theory) complete)
>>
>> The preferred method for sending a patch would be to fork the scons repo
>> and send a pull request.
>> Any chance we can ask you to do that?
>> That way the version history would properly represent who made the fix.
>>
>> -Bill
>>
>>
>> On Wed, Sep 16, 2015 at 7:35 AM, Florian Miedniak <
>> florian.miedn...@web.de> wrote:
>>>
>>> Hi,
>>>
>>> first of all, I'm very glad scons now has support for exclude patterns
>>> for Glob()! Compared to the prior workarounds the solution IMO fits
>>> perfectly in the scons way of declaring artifacts.
>>>
>>> Nevertheless, I think I've found a bug or at least a from my point of
>>> view unexpected behaviour when using Glob-excludes together with variant
>>> dirs: When Glob is called within a separate SConscript, it fails to
>>> properly apply exclude patterns because the returned list of files contains
>>> path information (see attached testcase for details).
>>>
>>> I think I found the place in FS.py (SCons 2.3.6) where things go wrong.
>>> With attached patch, the problem went away for me. But I'm not yet sure, if
>>> I really found the root cause or just a workaround. In addition to that,
>>> I'm very uncertain about possible side-effects of the patch ...
>>> So I'd very like someone to review both the testcase and, if it is
>>> considered valid, the proposed patch.
>>>
>>> An additional note: While tracking down the problem, I found these issue
>>> 2545 in state NEW whereas Git commits fc2659e and 81e0a43 seem
>>> to fix this issue. Does the issue still being in state NEW mean, that
>>> implementation of the exclude feature is considered still incomplete?
>>>
>>>
>>> Regards,
>>> -Florian
>>>
>>> ___
>>> Scons-users mailing list
>>> scons-us...@scons.org
>>> https://pairlist4.pair.net/mailman/listinfo/scons-users
>>>
>>
>> ___ Scons-users mailing list
>> scons-us...@scons.org
>> https://pairlist4.pair.net/mailman/listinfo/scons-users
>>
>> ___
>> Scons-users mailing list
>> scons-us...@scons.org
>> https://pairlist4.pair.net/mailman/listinfo/scons-users
>>
>
> ___ Scons-users mailing list
> scons-us...@scons.org
> https://pairlist4.pair.net/mailman/listinfo/scons-users
> ___ Scons-users mailing list
>

Re: [Scons-dev] Fw: Re: [Scons-users] Glob() exclude doesn't match when used inside VariantDir

2015-09-24 Thread Bill Deegan 
We usually use target milestone for planning and not for keeping track of
when bugs are fixed.
For that the bug #'s should be in the blurb in src/CHANGES.txt

So no need to do anything further.

-Bill

On Wed, Sep 23, 2015 at 11:49 PM, Florian Miedniak <
florian.miedn...@gmail.com> wrote:

> Great to see the fix being merged upstream within a week! One question
> left: Shall I leave the tigris issue in state RESOLVED:FIXED with target
> milestone UNSPECIFIED? Or shall I set target milestone to 2.x (and leaving
> it open)? What is the recommended way to ensure that solved tickets like
> this get closed on (next) release?
>
> -Florian
>
> 2015-09-24 8:47 GMT+02:00 Florian Miedniak :
>
>>
>>
>> *Gesendet:* Dienstag, 22. September 2015 um 12:43 Uhr
>> *Von:* "Florian Miedniak" 
>> *An:* scons-dev@scons.org
>> *Betreff:* [Scons-dev] Fw: Re: [Scons-users] Glob() exclude doesn't
>> match when used inside VariantDir
>> Posted, just to preserve the thread history from scons-user list.
>>
>> *Gesendet:* Dienstag, 22. September 2015 um 12:00 Uhr
>> *Von:* "William L Blevins" 
>> *An:* "SCons users mailing list" 
>> *Betreff:* Re: [Scons-users] Glob() exclude doesn't match when used
>> inside VariantDir
>>
>> I would argue it's more for the developer list now.
>>
>> V/R,
>> William
>>
>>
>> On September 22, 2015, at 10:39 AM, Florian Miedniak <
>> florian.miedn...@web.de> wrote:
>>
>>
>> Hi Bill,
>>
>> I just created a pull request for the issue:
>> https://bitbucket.org/scons/scons/pull-requests/252/fixed-3011-glob-called-with-exclude-didnt/diff
>>
>> Notes:
>> - Is it okay to discuss this further on scons-user?
>> - [offtopic] I just did a python bootstrap.py and was overwhelmed how
>> simply it is to "build" SCons! The people maintaining our development
>> environment just couldn't believe getting a rpm with a local scons build
>> including my changes for deployment ...
>>
>> -Florian
>>
>> *Gesendet:* Donnerstag, 17. September 2015 um 15:24 Uhr
>> *Von:* "Bill Deegan" 
>> *An:* "SCons users mailing list" 
>> *Betreff:* Re: [Scons-users] Glob() exclude doesn't match when used
>> inside VariantDir
>> Thanks!
>> -Bill
>>
>> On Thu, Sep 17, 2015 at 3:40 AM, Florian Miedniak <
>> florian.miedn...@web.de> wrote:
>>>
>>> Hi Bill,
>>>
>>> I just created an issue in bug tracker (#3011) and will provide a pull
>>> request as you suggested for further discussion.
>>>
>>> -Florian
>>>
>>> *Gesendet:* Mittwoch, 16. September 2015 um 16:46 Uhr
>>> *Von:* "Bill Deegan" 
>>> *An:* "SCons users mailing list" 
>>> *Betreff:* Re: [Scons-users] Glob() exclude doesn't match when used
>>> inside VariantDir
>>> Florian,
>>>
>>> Good catch on the bug still being open. I've closed it. (It should have
>>> been as the feature is (in theory) complete)
>>>
>>> The preferred method for sending a patch would be to fork the scons repo
>>> and send a pull request.
>>> Any chance we can ask you to do that?
>>> That way the version history would properly represent who made the fix.
>>>
>>> -Bill
>>>
>>>
>>> On Wed, Sep 16, 2015 at 7:35 AM, Florian Miedniak <
>>> florian.miedn...@web.de> wrote:

 Hi,

 first of all, I'm very glad scons now has support for exclude patterns
 for Glob()! Compared to the prior workarounds the solution IMO fits
 perfectly in the scons way of declaring artifacts.

 Nevertheless, I think I've found a bug or at least a from my point of
 view unexpected behaviour when using Glob-excludes together with variant
 dirs: When Glob is called within a separate SConscript, it fails to
 properly apply exclude patterns because the returned list of files contains
 path information (see attached testcase for details).

 I think I found the place in FS.py (SCons 2.3.6) where things go
 wrong. With attached patch, the problem went away for me. But I'm not yet
 sure, if I really found the root cause or just a workaround. In addition to
 that, I'm very uncertain about possible side-effects of the patch ...
 So I'd very like someone to review both the testcase and, if it is
 considered valid, the proposed patch.

 An additional note: While tracking down the problem, I found these
 issue 2545 in state NEW whereas Git commits fc2659e and 81e0a43 seem
 to fix this issue. Does the issue still being in state NEW mean, that
 implementation of the exclude feature is considered still incomplete?


 Regards,
 -Florian

 ___
 Scons-users mailing list
 scons-us...@scons.org
 https://pairlist4.pair.net/mailman/listinfo/scons-users

>>>
>>> ___ Scons-users mailing list
>>> scons-us...@scons.org
>>>

Re: [Scons-dev] Roundup tracker demo instance...

2015-09-24 Thread William Blevins 
I took a quick peek.  Couldn't log in with demo/demo.  I got an invalid
page address error.

What advantage will this give us over tigris?  I realize it's a demo, but
the example seems rather basic.

V/R,
William

On Thu, Sep 24, 2015 at 6:55 PM, Dirk Bächle  wrote:

> Hi there,
>
> I have imported the current bugs from our Tigris bug tracker (as of
> 2015-09-22) into a Roundup demo instance. It's running on one of my
> machines behind a DSL router, and will be available over the weekend at:
>
>   http://dirkbaechle.dyndns.org:8917/demo/
>
> Please take into account that my internet connection is not the fastest,
> so be patient. ;)
>
> I tried to come up with a basic, more SConsy, design...sorry if it hurts
> your eyes.
> Just use the chance to snoop around and get a first impression of what a
> Roundup tracker for SCons might look like.
>
> TODOs so far:
>
> - Switch to the "python-devel" template, such that we have some additional
> fields like "Dependencies".
> - Come up with an idea about how to initialize the user's passwords (you
> can login as demo/demo, or as a existing user with an empty password, at
> the moment) and their EMail addresses.
>
>
> Your comments and thoughts are welcome.
>
> Best regards,
>
> Dirk
> ___
> Scons-dev mailing list
> Scons-dev@scons.org
> https://pairlist2.pair.net/mailman/listinfo/scons-dev
>
___
Scons-dev mailing list
Scons-dev@scons.org
https://pairlist2.pair.net/mailman/listinfo/scons-dev

Re: [Scons-dev] Roundup tracker demo instance...

2015-09-24 Thread Dirk Bächle 

On 24.09.2015 20:01, William Blevins wrote:

I took a quick peek.  Couldn't log in with demo/demo.  I got an invalid page 
address error.



Hmm, don't know...this is new to me. It worked when I tested it from "localhost", I guess that's the difference. Can't do much about 
it right now, due to a lack of time.

So everybody can only "look", I'm sorry about this inconvenience.


What advantage will this give us over tigris?  I realize it's a demo, but the 
example seems rather basic.


Where "basic" refers to? Design? Functionality?

Dirk


___
Scons-dev mailing list
Scons-dev@scons.org
https://pairlist2.pair.net/mailman/listinfo/scons-dev

Re: [Scons-dev] Roundup tracker demo instance...

2015-09-24 Thread Gary Oberbrunner 
On Thu, Sep 24, 2015 at 2:17 PM, William Blevins 
wrote:

> Functionality wise, what does round-up provide that tigris doesn't?


Lack of awfulness.  IMHO of course. :-)

-- 
Gary
___
Scons-dev mailing list
Scons-dev@scons.org
https://pairlist2.pair.net/mailman/listinfo/scons-dev

[Scons-dev] Roundup tracker demo instance...

2015-09-24 Thread Dirk Bächle 

Hi there,

I have imported the current bugs from our Tigris bug tracker (as of 2015-09-22) into a Roundup demo instance. It's running on one of 
my machines behind a DSL router, and will be available over the weekend at:


  http://dirkbaechle.dyndns.org:8917/demo/

Please take into account that my internet connection is not the fastest, so be 
patient. ;)

I tried to come up with a basic, more SConsy, design...sorry if it hurts your 
eyes.
Just use the chance to snoop around and get a first impression of what a 
Roundup tracker for SCons might look like.

TODOs so far:

- Switch to the "python-devel" template, such that we have some additional fields like 
"Dependencies".
- Come up with an idea about how to initialize the user's passwords (you can login as demo/demo, or as a existing user with an empty 
password, at the moment) and their EMail addresses.



Your comments and thoughts are welcome.

Best regards,

Dirk
___
Scons-dev mailing list
Scons-dev@scons.org
https://pairlist2.pair.net/mailman/listinfo/scons-dev

Re: [Scons-dev] Roundup tracker demo instance...

2015-09-24 Thread William Blevins 
On Thu, Sep 24, 2015 at 7:10 PM, Dirk Bächle  wrote:

> On 24.09.2015 20:01, William Blevins wrote:
>
>> I took a quick peek.  Couldn't log in with demo/demo.  I got an invalid
>> page address error.
>>
>>
> Hmm, don't know...this is new to me. It worked when I tested it from
> "localhost", I guess that's the difference. Can't do much about it right
> now, due to a lack of time.
> So everybody can only "look", I'm sorry about this inconvenience.
>
> What advantage will this give us over tigris?  I realize it's a demo, but
>> the example seems rather basic.
>>
>> Where "basic" refers to? Design? Functionality?


I'm not terribly concerned what it looks like though I'd prefer light on
dark (HCI friendly colors).  Functionality wise, what does round-up provide
that tigris doesn't?

>
>
> Dirk
>
>
> ___
> Scons-dev mailing list
> Scons-dev@scons.org
> https://pairlist2.pair.net/mailman/listinfo/scons-dev
>
___
Scons-dev mailing list
Scons-dev@scons.org
https://pairlist2.pair.net/mailman/listinfo/scons-dev