Hi William,
On 22.09.2016 05:39, William Blevins wrote:
Administrators,
I have a lot of stuff in that PR now. Look at it and decide if it's fine.
this looks great! Let's merge it as is, and then continue by opening another branch right away. Regarding the "fixture"s, it's okay
with me if yo
On 22.09.2016 18:40, Dirk Bächle wrote:
Hi William,
On 22.09.2016 05:39, William Blevins wrote:
Administrators,
I have a lot of stuff in that PR now. Look at it and decide if it's fine.
this looks great! Let's merge it as is, and then continue by opening another
branch right away.
...or
The current PR is from default; I'm just using bookmarks.
Tim's changes have not been merged. I looked through them. A lot of his
changes are equivalent to the ones in my current PR which includes futurize
-2 -f "2to3*". He and I probably need to see if there is anything different
that I haven't i
On 22.09.2016 19:21, William Blevins wrote:
The current PR is from default; I'm just using bookmarks.
Sorry, I hadn't noticed...all the better then. ;)
Dirk
___
Scons-dev mailing list
Scons-dev@scons.org
https://pairlist2.pair.net/mailman/listinfo
No worries. Some others are not, so it's a fair point.
On Thu, Sep 22, 2016 at 1:53 PM, Dirk Bächle wrote:
> On 22.09.2016 19:21, William Blevins wrote:
>
>> The current PR is from default; I'm just using bookmarks.
>>
>>
> Sorry, I hadn't noticed...all the better then. ;)
>
>
> Dirk
>
>
> _
William,
Looks like a couple new failures.
http://buildbot.scons.org/builders/bd-ubuntu-python-2.7/builds/43/steps/shell/logs/stdio
Can you take a look and resolve if possible?
Thanks,
Bill
On Thu, Sep 22, 2016 at 10:55 AM, William Blevins
wrote:
> No worries. Some others are not, so it's a f
Yes.
On Thu, Sep 22, 2016 at 4:47 PM, Bill Deegan
wrote:
> William,
>
> Looks like a couple new failures.
> http://buildbot.scons.org/builders/bd-ubuntu-python-2.7/
> builds/43/steps/shell/logs/stdio
>
> Can you take a look and resolve if possible?
>
> Thanks,
> Bill
>
> On Thu, Sep 22, 2016 at
1. test/Actions/pre-post.py
I moved the file writes into a fixture. On my machine this is fine, I
wonder if the QMTest dir_fixture/file_fixture FS commands hadn't written to
disk before the test script ran?
2. test/Parallel/build_failure.py
I didn't change this file. Since it has sleep commands,
Bill,
Do you know if the QMTest fixture commands have been used in anger? That
first issue worries me a bit. The later one, not so much.
V/R,
William
On Thu, Sep 22, 2016 at 5:56 PM, William Blevins
wrote:
> 1. test/Actions/pre-post.py
>
> I moved the file writes into a fixture. On my machine
Looks like this was removed:
-
-test.write(['work4', 'build.py'], """\
-import sys
-outfp = open(sys.argv[1], 'wb')
-for f in sys.argv[2:]:
-outfp.write(open(f, 'rb').read())
-outfp.close()
-""")
But no file added to the fixture.
I've fixed and pushed. I'm betting it's in your local r
In the .hgignore file, the first line "build" is apparently causing
"build.py" to be skipped. I assume this is because it exists before the
syntax:glob. Do you know the purpose of the first 2 lines. They are
probably not behaving as intended.
V/R,
William
On Thu, Sep 22, 2016 at 6:16 PM, Bill Dee
when you run bootstrap.py it creates the build and bootstrap directory
trees.
Those shouldn't be added to source control.
Perhaps they're not specified specifically enough
-Bill
On Thu, Sep 22, 2016 at 3:30 PM, William Blevins
wrote:
> In the .hgignore file, the first line "build" is apparently
Not if those patterns match anything in the relative path for a file :)
On Thu, Sep 22, 2016 at 7:03 PM, Bill Deegan
wrote:
> when you run bootstrap.py it creates the build and bootstrap directory
> trees.
> Those shouldn't be added to source control.
> Perhaps they're not specified specifically
Maybe add a slash after “build”? So “build/"
> On Sep 22, 2016, at 16:03, Bill Deegan wrote:
>
> when you run bootstrap.py it creates the build and bootstrap directory trees.
> Those shouldn't be added to source control.
> Perhaps they're not specified specifically enough
>
> -Bill
>
> On Thu,
Yeah that's what I was thinking. Not foolproof but better. Will that work
on Windows?
On Thu, Sep 22, 2016 at 7:04 PM, Tim Jenness wrote:
> Maybe add a slash after “build”? So “build/"
>
> On Sep 22, 2016, at 16:03, Bill Deegan wrote:
>
> when you run bootstrap.py it creates the build and boots
Team,
As Bill and I briefly discussed in a PR, we thought it would be nice if we
could have various directories to pull fixtures. I made the locations into
a list, and added a global share directory for reusing files that get copy
pasta lots.
Please take a look at this diff which also includes fi
16 matches
Mail list logo