code review please

2009-08-20 Thread Gabor Szabo
Hi, I have started to write and SDL plugin for Padre and to help me learn a bit of SDL I wrote a few sample scripts. I'd appreciate if someone looked at them and told me how could they be improved. They can be found at http://svn.perlide.org/padre/trunk/Padre-Plugin-SDL/share/examples/ I have

Re: code review please

2009-08-20 Thread Kartik Thakore
Hi, Hi I have started to write and SDL plugin for Padre and to help me learn a bit of SDL I wrote a few sample scripts. Nice! I'd appreciate if someone looked at them and told me how could they be improved. I noticed use SDL; was missing for a lot of the scripts. Also when you make a

Re: code review please

2009-08-20 Thread Gabor Szabo
On Thu, Aug 20, 2009 at 5:52 PM, Kartik Thakorethakore.kar...@gmail.com wrote: Hi, I'd appreciate if someone looked at them and told me how could they be improved. I noticed use SDL; was missing for a lot of the scripts. Also when you make a new SDL::Event please do use SDL::Event; Is

Re: code review please

2009-08-20 Thread Gabor Szabo
On Thu, Aug 20, 2009 at 7:07 PM, Kartik Thakorethakore.kar...@gmail.com wrote: but it is at least as slow if not slower with 1.20.3 that came with Ubuntu Is there a script I can use as a benchmark? You can use any of those script - at least the ones that are not interactive but my point is

Re: code review please

2009-08-20 Thread Kartik Thakore
Hi On Thu, Aug 20, 2009 at 5:52 PM, Kartik Thakorethakore.kar...@gmail.com wrote: Hi, I'd appreciate if someone looked at them and told me how could they be improved. I noticed use SDL; was missing for a lot of the scripts. Also when you make a new SDL::Event please do use