Re: [SeaBIOS] why need 32bit code in seabios?

2012-07-20 Thread Darmawan Salihun
Hi, I'm not sure about it, but probably for BIOS32 Service Directory. Regards, Darmawan On 7/20/12, wx fred...@hotmail.com wrote: Hi, I have a Childish question,why need 32bit code in seabios?. I found some files are compiled in 16bit and 32bit twice.Thanks!

Re: [SeaBIOS] why need 32bit code in seabios?

2012-07-20 Thread Darmawan Salihun
On 7/20/12, wx fred...@hotmail.com wrote: Hi, I have a Childish question,why need 32bit code in seabios?. I found some files are compiled in 16bit and 32bit twice.Thanks! Hi, I'm not 100% sure about SeaBIOS, but there is this thing

Re: [SeaBIOS] [PATCH 2/2] lsi53c895a boot support

2012-07-20 Thread Gerd Hoffmann
Hi, +/* FIXME: probably not the best idea to have this on the stack ... */ +u32 script[] = { Several places in the code DMA to the stack already (usb-ehci, usb-uhci, ata). My concern isn't DMA'ing to the stack, but the size of the script and possible stack overruns. But maybe it

Re: [SeaBIOS] [RFC PATCH v2 03/21] acpi-dsdt: Implement functions for memory hotplug

2012-07-20 Thread Vasilis Liaskovitis
On Tue, Jul 17, 2012 at 03:23:00PM +0800, Wen Congyang wrote: +Method(MESC, 0) { +// Local5 = active memdevice bitmap +Store (MES, Local5) +// Local2 = last read byte from bitmap +Store (Zero, Local2) +// Local0 =

[SeaBIOS] [PATCH v2 1/3] move usb mass storage defines to usb.h

2012-07-20 Thread Gerd Hoffmann
With the arrival of usb attached scsi support they will be needed outside usb-msd.c too. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- src/usb-msc.h | 11 --- src/usb.h | 10 ++ 2 files changed, 10 insertions(+), 11 deletions(-) diff --git a/src/usb-msc.h

[SeaBIOS] [PATCH v2 0/3] scsi boot

2012-07-20 Thread Gerd Hoffmann
Hi, Quick review, giving me the opportunity for a quick v2 before disappearing into my summer vacation, fixing the nits pointed out by Kevin. The series also got a third commit which moves the usb mass storage defines from usb-msc.h to usb.h, so the uas code can easily reuse them. cheers,

[SeaBIOS] [PATCH v2 3/3] lsi53c895a boot support

2012-07-20 Thread Gerd Hoffmann
This patch adds support for the lsi53c895a scsi host adapter, allowing seabios to boot from scsi disks and cdroms connected to the lsi scsi hba emulated by qemu. This driver was written by looking at the expectations of qemu's lsi emulation. I have no idea idea how close this is to work on real

[SeaBIOS] [PATCH v2 2/3] usb attached scsi boot support

2012-07-20 Thread Gerd Hoffmann
This patch adds support for booting from UAS (usb attached scsi) devices. For now only usb 2.0 support is there. On usb 3.0 the UAS protocol uses streams, so changes will be required to make usb 3.0 devices fly once we have a xhci host controller driver. So far the driver has been tested on

Re: [SeaBIOS] [PATCH]: enable USE_PLATFORM_CLOCK bit in FADT flags

2012-07-20 Thread Marcelo Tosatti
On Fri, Jul 20, 2012 at 07:49:03AM +0300, Gleb Natapov wrote: On Thu, Jul 19, 2012 at 08:44:07PM -0400, Kevin O'Connor wrote: On Tue, Jul 17, 2012 at 02:18:00PM -0300, Marcelo Tosatti wrote: Enable bit 15 (USE_PLATFORM_CLOCK) of FADT flags field so that older Windows guests do not

Re: [SeaBIOS] [PATCH 2/2] lsi53c895a boot support

2012-07-20 Thread Kevin O'Connor
On Fri, Jul 20, 2012 at 09:33:05AM +0200, Gerd Hoffmann wrote: Hi, +/* FIXME: probably not the best idea to have this on the stack ... */ +u32 script[] = { Several places in the code DMA to the stack already (usb-ehci, usb-uhci, ata). My concern isn't DMA'ing to the

Re: [SeaBIOS] [PATCH]: enable USE_PLATFORM_CLOCK bit in FADT flags

2012-07-20 Thread Gleb Natapov
On Fri, Jul 20, 2012 at 07:24:27AM -0300, Marcelo Tosatti wrote: On Fri, Jul 20, 2012 at 07:49:03AM +0300, Gleb Natapov wrote: On Thu, Jul 19, 2012 at 08:44:07PM -0400, Kevin O'Connor wrote: On Tue, Jul 17, 2012 at 02:18:00PM -0300, Marcelo Tosatti wrote: Enable bit 15

Re: [SeaBIOS] [PATCH 2/2] lsi53c895a boot support

2012-07-20 Thread Gerd Hoffmann
On 07/20/12 14:47, Kevin O'Connor wrote: On Fri, Jul 20, 2012 at 09:33:05AM +0200, Gerd Hoffmann wrote: My concern isn't DMA'ing to the stack, but the size of the script and possible stack overruns. But maybe it is a moot point with the stack switching added to seabios recently. Disk

Re: [SeaBIOS] [seabios PATCH 1/2] acpi: set I/O APIC ID to 0 by default

2012-07-20 Thread Eduardo Habkost
On Fri, Jul 20, 2012 at 12:18:59AM +0300, Gleb Natapov wrote: On Thu, Jul 19, 2012 at 05:52:41PM -0300, Eduardo Habkost wrote: When resetting an I/O APIC, its ID is set to 0, so set it to 0 on the MADT table too. Actually BIOS needs to configure ioapic id to a uniqe value. This does not

[SeaBIOS] [SeaBIOS PATCH 1/2] acpi: report real I/O APIC ID (0) on MADT table (v2)

2012-07-20 Thread Eduardo Habkost
When resetting an I/O APIC, its ID is set to 0, and SeaBIOS doesn't change it, so report it correctly on the MADT table. Some hardware may require the BIOS to initialize I/O APIC ID to an unique value, but SeaBIOS doesn't do that. This patch at least makes the MADT table reflect reality. Changes

[SeaBIOS] [SeaBIOS PATCH 2/2] allow CPUs to have non-contiguous Local APIC IDs (v2)

2012-07-20 Thread Eduardo Habkost
Extract Local APIC IDs directly from the CPUs, and instead of check for i CountCPUs, check if the APIC ID was present on boot, when building ACPI tables and the MP-Table. This keeps ACPI Processor ID == APIC ID, but allows the hardware-SeaBIOS interface be completely APIC-ID based and not depend

[SeaBIOS] [SeaBIOS PATCH 0/2] Allow non-contiguous APIC IDs (v2)

2012-07-20 Thread Eduardo Habkost
Small changes from the previous series: - Patch 1/2: cosmetic whitespace change - Patch 2/2: use size suffixes on asm instructions on smp.c - New patch descriptions Eduardo Habkost (2): acpi: report real I/O APIC ID (0) on MADT table allow CPUs to have non-contiguous Local APIC IDs (v2)