Re: [SeaBIOS] [PATCH 2/2] accept MADT over fw_cfg

2013-03-21 Thread Michael S. Tsirkin
On Wed, Mar 20, 2013 at 08:22:30PM -0400, Kevin O'Connor wrote: On Wed, Mar 20, 2013 at 10:53:05PM +0100, Laszlo Ersek wrote: Signed-off-by: Laszlo Ersek ler...@redhat.com I think we need to figure out what the final fw_cfg interface for ACPI, SMBIOS, mptable, and PIR will be. We can

Re: [SeaBIOS] [PATCH v3] pciinit: Enable default VGA device

2013-03-21 Thread Gerd Hoffmann
On 03/20/13 17:58, Alex Williamson wrote: As QEMU gains PCI bridge and PCIe root port support, we won't always find the VGA device on the root bus. We therefore need to add support to find and enable a VGA device and the path to it through the VGA Enable support in the PCI bridge control

Re: [SeaBIOS] [PATCH please reply] make acpi bits GPLv2 compatible

2013-03-21 Thread Christensson, Magnus
Acked-by: Magnus Christensson magnus.christens...@intel.com M. -Original Message- From: seabios-boun...@seabios.org [mailto:seabios-boun...@seabios.org] On Behalf Of Michael S. Tsirkin Sent: Wednesday, March 20, 2013 4:58 PM To: seabios@seabios.org Cc: Woodhouse, David; Magnus

[SeaBIOS] [PATCH v15 1/2] add pvpanic device driver

2013-03-21 Thread Hu Tao
pvpanic device is used to notify host(qemu) when guest panic happens. Signed-off-by: Hu Tao hu...@cn.fujitsu.com --- ref: http://lists.nongnu.org/archive/html/qemu-devel/2013-03/msg03630.html The version number is 15 to consist with qemu patches. src/acpi-dsdt-isa.dsl | 30

Re: [SeaBIOS] [PATCH v15 2/2] patch dsdt to use passed-in pvpanic ioport

2013-03-21 Thread Paolo Bonzini
Il 21/03/2013 10:08, Hu Tao ha scritto: Signed-off-by: Hu Tao hu...@cn.fujitsu.com --- src/acpi-dsdt-isa.dsl | 14 -- src/acpi.c| 9 + 2 files changed, 21 insertions(+), 2 deletions(-) diff --git a/src/acpi-dsdt-isa.dsl b/src/acpi-dsdt-isa.dsl index

Re: [SeaBIOS] [PATCH v15 2/2] patch dsdt to use passed-in pvpanic ioport

2013-03-21 Thread Hu Tao
On Thu, Mar 21, 2013 at 10:11:54AM +0100, Paolo Bonzini wrote: Il 21/03/2013 10:08, Hu Tao ha scritto: Signed-off-by: Hu Tao hu...@cn.fujitsu.com --- src/acpi-dsdt-isa.dsl | 14 -- src/acpi.c| 9 + 2 files changed, 21 insertions(+), 2 deletions(-)

Re: [SeaBIOS] [PATCH v15 2/2] patch dsdt to use passed-in pvpanic ioport

2013-03-21 Thread Michael S. Tsirkin
On Thu, Mar 21, 2013 at 05:08:34PM +0800, Hu Tao wrote: Signed-off-by: Hu Tao hu...@cn.fujitsu.com OK now you need to ACK GPLv2+ relicensing too :) Could you please review that message make acpi bits GPLv2 compatible and respond? --- src/acpi-dsdt-isa.dsl | 14 -- src/acpi.c

Re: [SeaBIOS] [PATCH please reply] make acpi bits GPLv2 compatible

2013-03-21 Thread Hu Tao
Acked-by: Hu Tao hu...@cn.fujitsu.com On Wed, Mar 20, 2013 at 05:57:53PM +0200, Michael S. Tsirkin wrote: You are getting this mail because you might have contributed code to one of the files in seabios that we want to reuse in QEMU, when this file was under GPLv3 or LGPLv3. QEMU is GPLv2

Re: [SeaBIOS] [PATCH 2/2] accept MADT over fw_cfg

2013-03-21 Thread Michael S. Tsirkin
On Thu, Mar 21, 2013 at 09:18:50AM +0100, Gerd Hoffmann wrote: On 03/21/13 07:23, Michael S. Tsirkin wrote: On Wed, Mar 20, 2013 at 08:22:30PM -0400, Kevin O'Connor wrote: On Wed, Mar 20, 2013 at 10:53:05PM +0100, Laszlo Ersek wrote: Signed-off-by: Laszlo Ersek ler...@redhat.com I

[SeaBIOS] [PATCH] README: document which config options to use

2013-03-21 Thread Michael S. Tsirkin
In the interim of moving ACPI tables out of seabios, developers should get the config from QEMU tree to keep things in sync. Signed-off-by: Michael S. Tsirkin m...@redhat.com --- README | 6 ++ 1 file changed, 6 insertions(+) diff --git a/README b/README index a87a0ad..380fc80 100644 ---

Re: [SeaBIOS] [PATCH] README: document which config options to use

2013-03-21 Thread Michael S. Tsirkin
On Thu, Mar 21, 2013 at 01:22:33PM +0100, Laszlo Ersek wrote: On 03/21/13 13:03, Michael S. Tsirkin wrote: In the interim of moving ACPI tables out of seabios, developers should get the config from QEMU tree to keep things in sync. Signed-off-by: Michael S. Tsirkin m...@redhat.com

[SeaBIOS] [PATCH] README: document which config options to use

2013-03-21 Thread Michael S. Tsirkin
In the interim of moving ACPI tables out of seabios, developers should get the config from QEMU tree to keep things in sync. Signed-off-by: Michael S. Tsirkin m...@redhat.com --- README | 16 ++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/README b/README index

Re: [SeaBIOS] [PATCH] README: document which config options to use

2013-03-21 Thread Laszlo Ersek
On 03/21/13 13:30, Michael S. Tsirkin wrote: In the interim of moving ACPI tables out of seabios, developers should get the config from QEMU tree to keep things in sync. Signed-off-by: Michael S. Tsirkin m...@redhat.com --- README | 16 ++-- 1 file changed, 14 insertions(+),

Re: [SeaBIOS] [PATCH 2/2] accept MADT over fw_cfg

2013-03-21 Thread Gerd Hoffmann
Hi, How about we don't bother to determine this at runtime at all? Because it will be a PITA for testers + developers to figure the correct .config switches of the day during the transition phase? Why is it a PITA? Are you developing QEMU? Just use the makefile from

Re: [SeaBIOS] [PATCH 2/2] accept MADT over fw_cfg

2013-03-21 Thread David Woodhouse
On Thu, 2013-03-21 at 13:49 +0100, Gerd Hoffmann wrote: How about we don't bother to determine this at runtime at all? Because it will be a PITA for testers + developers to figure the correct .config switches of the day during the transition phase? Why is it a PITA? Are you

Re: [SeaBIOS] [PATCH 2/2] accept MADT over fw_cfg

2013-03-21 Thread Laszlo Ersek
On 03/21/13 13:23, David Woodhouse wrote: On Wed, 2013-03-20 at 20:22 -0400, Kevin O'Connor wrote: On Wed, Mar 20, 2013 at 10:53:05PM +0100, Laszlo Ersek wrote: Signed-off-by: Laszlo Ersek ler...@redhat.com I think we need to figure out what the final fw_cfg interface for ACPI, SMBIOS,

Re: [SeaBIOS] [PATCH 2/2] accept MADT over fw_cfg

2013-03-21 Thread Michael S. Tsirkin
On Thu, Mar 21, 2013 at 01:49:36PM +0100, Gerd Hoffmann wrote: Hi, How about we don't bother to determine this at runtime at all? Because it will be a PITA for testers + developers to figure the correct .config switches of the day during the transition phase? Why is it a PITA?

Re: [SeaBIOS] [PATCH 2/2] accept MADT over fw_cfg

2013-03-21 Thread David Woodhouse
On Thu, 2013-03-21 at 13:56 +0100, Laszlo Ersek wrote: - for an earlier qemu, the option must be set, - for a later qemu the option must be clear (no -acpitable switch must be specified on the qemu cmldine || one -acpitable switch must load a MADT) Hm, that sounds like it won't be

Re: [SeaBIOS] [PATCH 2/2] accept MADT over fw_cfg

2013-03-21 Thread David Woodhouse
On Thu, 2013-03-21 at 15:12 +0200, Michael S. Tsirkin wrote: On Thu, Mar 21, 2013 at 01:04:35PM +, David Woodhouse wrote: On Thu, 2013-03-21 at 13:56 +0100, Laszlo Ersek wrote: - for an earlier qemu, the option must be set, - for a later qemu the option must be clear (no

Re: [SeaBIOS] [PATCH 2/2] accept MADT over fw_cfg

2013-03-21 Thread Michael S. Tsirkin
On Thu, Mar 21, 2013 at 01:14:38PM +, David Woodhouse wrote: On Thu, 2013-03-21 at 15:12 +0200, Michael S. Tsirkin wrote: On Thu, Mar 21, 2013 at 01:04:35PM +, David Woodhouse wrote: On Thu, 2013-03-21 at 13:56 +0100, Laszlo Ersek wrote: - for an earlier qemu, the option must be

Re: [SeaBIOS] [PATCH 2/2] accept MADT over fw_cfg

2013-03-21 Thread Gerd Hoffmann
Hi, But I'm not sure I see any point in doing it table-by-table. Surely it can be all or nothing? It allows to merge changes piecewise and avoids piling up long patch queues. It makes bisecting regressions easier. Also the logic if table $foo is provided by qemu, just use it, otherwise

Re: [SeaBIOS] [PATCH 2/2] accept MADT over fw_cfg

2013-03-21 Thread David Woodhouse
On Wed, 2013-03-20 at 20:22 -0400, Kevin O'Connor wrote: On Wed, Mar 20, 2013 at 10:53:05PM +0100, Laszlo Ersek wrote: Signed-off-by: Laszlo Ersek ler...@redhat.com I think we need to figure out what the final fw_cfg interface for ACPI, SMBIOS, mptable, and PIR will be. Once we have

[SeaBIOS] [PATCH 2/2 v2] Introduce CONFIG_ACPI_MADT to possibly prevent SeaBIOS from building MADT

2013-03-21 Thread Laszlo Ersek
This config option, when set to N, allows any qemu-built MADT to take precedence. Signed-off-by: Laszlo Ersek ler...@redhat.com --- in v2: - replaced primitive dynamic detection code with static config option - 352 bytes saved in 32bit flat init when set to N (RHEL-6 gcc-4.4.7) v2 depends on

Re: [SeaBIOS] [PATCH v15 2/2] patch dsdt to use passed-in pvpanic ioport

2013-03-21 Thread Kevin O'Connor
On Thu, Mar 21, 2013 at 05:08:34PM +0800, Hu Tao wrote: Signed-off-by: Hu Tao hu...@cn.fujitsu.com I don't think it is a good idea to dynamically modify the DSDT. We've been using the SSDT for that. In any case, I think this would be a good candidate for merging after the ACPI stuff is moved

Re: [SeaBIOS] [PATCH 2/2] accept MADT over fw_cfg

2013-03-21 Thread Kevin O'Connor
On Thu, Mar 21, 2013 at 03:04:37PM +0100, Gerd Hoffmann wrote: Today you can clone upstream seabios, build it, and the resulting image will work on pretty much any qemu version since 0.12 or so. You don't have to pick the correct config switches for your particular qemu version, it just

Re: [SeaBIOS] [PATCH 2/2] accept MADT over fw_cfg

2013-03-21 Thread Kevin O'Connor
On Thu, Mar 21, 2013 at 09:18:50AM +0100, Gerd Hoffmann wrote: On 03/21/13 07:23, Michael S. Tsirkin wrote: On Wed, Mar 20, 2013 at 08:22:30PM -0400, Kevin O'Connor wrote: On Wed, Mar 20, 2013 at 10:53:05PM +0100, Laszlo Ersek wrote: Signed-off-by: Laszlo Ersek ler...@redhat.com I

Re: [SeaBIOS] [PATCH 2/2] accept MADT over fw_cfg

2013-03-21 Thread Kevin O'Connor
On Thu, Mar 21, 2013 at 03:26:26PM +0200, Michael S. Tsirkin wrote: On Thu, Mar 21, 2013 at 01:14:38PM +, David Woodhouse wrote: On Thu, 2013-03-21 at 15:12 +0200, Michael S. Tsirkin wrote: Anyway, I am not against such runtime flags. If we add to this an option to build a minimal