Re: [SeaBIOS] [PATCH] init_virtio_scsi(): reset the HBA before freeing its virtio ring

2014-01-15 Thread Paolo Bonzini
Il 15/01/2014 02:48, Laszlo Ersek ha scritto: When init_virtio_scsi() finds no SCSI targets connected to the HBA, it frees the virtio ring. Other code in SeaBIOS proceeds to overwrite the area. However, the ring is in use by qemu at that point -- not only did we report the

[SeaBIOS] [Seabios] [PATCH v2] seabios: restore piix pm config registers after resume

2014-01-15 Thread Marcel Apfelbaum
On resume, the OS queries the power management event that caused it. In order to complete this task, it executes some reads to the piix pm io space. This all happens before the OS has a chance to restore the PCI config space for devices, so it is bios's responsibility to make sure the pm IO space

Re: [SeaBIOS] [PATCH] seabios: restore piix pm config registers after resume

2014-01-15 Thread Marcel Apfelbaum
On Mon, 2014-01-13 at 16:39 -0500, Kevin O'Connor wrote: On Mon, Jan 13, 2014 at 07:46:33PM +0200, Marcel Apfelbaum wrote: On Mon, 2014-01-13 at 11:31 -0500, Kevin O'Connor wrote: Thanks. SeaBIOS isn't responsible for PCI setup on CSM/coreboot, so the patch must check for CONFIG_QEMU.

Re: [SeaBIOS] [Qemu-devel] [Seabios] [PATCH v2] seabios: restore piix pm config registers after resume

2014-01-15 Thread Marcel Apfelbaum
On Wed, 2014-01-15 at 14:20 +0200, Marcel Apfelbaum wrote: On resume, the OS queries the power management event that caused it. In order to complete this task, it executes some reads to the piix pm io space. This all happens before the OS has a chance to restore the PCI config space for

Re: [SeaBIOS] [Seabios] [PATCH v2] seabios: restore piix pm config registers after resume

2014-01-15 Thread Michael S. Tsirkin
On Wed, Jan 15, 2014 at 02:20:06PM +0200, Marcel Apfelbaum wrote: On resume, the OS queries the power management event that caused it. In order to complete this task, it executes some reads to the piix pm io space. This all happens before the OS has a chance to restore the PCI config space for

Re: [SeaBIOS] [Qemu-devel] [Seabios] [PATCH v2] seabios: restore piix pm config registers after resume

2014-01-15 Thread Kevin O'Connor
On Wed, Jan 15, 2014 at 02:24:40PM +0200, Marcel Apfelbaum wrote: On Wed, 2014-01-15 at 14:20 +0200, Marcel Apfelbaum wrote: On resume, the OS queries the power management event that caused it. In order to complete this task, it executes some reads to the piix pm io space. This all happens

Re: [SeaBIOS] [Qemu-devel] [Seabios] [PATCH v2] seabios: restore piix pm config registers after resume

2014-01-15 Thread Marcel Apfelbaum
On Wed, 2014-01-15 at 11:04 -0500, Kevin O'Connor wrote: On Wed, Jan 15, 2014 at 02:24:40PM +0200, Marcel Apfelbaum wrote: On Wed, 2014-01-15 at 14:20 +0200, Marcel Apfelbaum wrote: On resume, the OS queries the power management event that caused it. In order to complete this task, it