Re: [SeaBIOS] [PATCH v2 3/3] pci: recognize RH PCI legacy bridge resource reservation capability

2018-08-15 Thread Zihan Yang
Liu, Jing2 于2018年8月16日周四 上午10:39写道: > > Hi Zihan, > > I copy your comments of this patch several days ago here, > and hope we could continue some discussion in this serial. Hi Jing, Sorry for the delay. I tested at the code just now and find that pcie bridge does not use a vendor specific

Re: [SeaBIOS] [PATCH v2 3/3] pci: recognize RH PCI legacy bridge resource reservation capability

2018-08-15 Thread Liu, Jing2
Hi Zihan, I copy your comments of this patch several days ago here, and hope we could continue some discussion in this serial. On 8/16/2018 10:32 AM, Jing Liu wrote: [...] static u8 pci_find_resource_reserve_capability(u16 bdf) { -if (pci_config_readw(bdf, PCI_VENDOR_ID) ==

Re: [SeaBIOS] [PATCH v2 0/3] pci: resource reserve capability found

2018-08-15 Thread Liu, Jing2
Hi all, I re-send the serial because of wrong numbering last time. Sorry for troubling. Thanks! Jing On 8/16/2018 10:32 AM, Jing Liu wrote: This patch serial is about QEMU resource reserve capability finding in firmware. Firstly, this fixes a logic bug. When the capability is truncated, return

[SeaBIOS] [PATCH v2 0/3] pci: resource reserve capability found

2018-08-15 Thread Jing Liu
This patch serial is about QEMU resource reserve capability finding in firmware. Firstly, this fixes a logic bug. When the capability is truncated, return zero instead of the truncated offset. Secondly, this modified the debug messages when the capability is not found and when the vendor ID or

[SeaBIOS] [PATCH v2 2/3] pci: clean up the debug message for pci capability found

2018-08-15 Thread Jing Liu
Improve the debug message when QEMU resource reserve cap is not found and when the vendor-id or device-id does't match REDHAT special ones. Signed-off-by: Jing Liu --- src/fw/pciinit.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/fw/pciinit.c b/src/fw/pciinit.c