Re: [SeaBIOS] [RFC v3] pciinit: setup mcfg for pxb-pcie to support multiple pci domains

2018-09-27 Thread Kevin O'Connor
On Thu, Sep 27, 2018 at 11:05:13PM +0800, Zihan Yang wrote: > Laszlo Ersek 于2018年9月26日周三 上午1:17写道: > > First, I fail to see the use case where ~256 PCI bus numbers aren't > > enough. If I strain myself, perhaps I can imagine using ~200 PCIe root > > ports on Q35 (each of which requires a separate

Re: [SeaBIOS] [PATCH] pretty boot menu entry for cdrom drives

2018-09-27 Thread Peter Stuge
Kevin O'Connor wrote: > it's a little odd to have a C function sometimes return a dynamically > allocated string and sometimes return a constant string. Gerd, please don't do that. Sure, maybe nothing is ever free()d, but that's still very poor practice. Don't spread it. //Peter

Re: [SeaBIOS] [RFC v3] pciinit: setup mcfg for pxb-pcie to support multiple pci domains

2018-09-27 Thread Dr. David Alan Gilbert
* Zihan Yang (whois.zihan.y...@gmail.com) wrote: > HI Laszlo > Laszlo Ersek 于2018年9月26日周三 上午1:17写道: > > > > On 09/25/18 17:38, Kevin O'Connor wrote: > > > On Mon, Sep 17, 2018 at 11:02:59PM +0800, Zihan Yang wrote: > > >> To support multiple pci domains of pxb-pcie device in qemu, we need to > >

Re: [SeaBIOS] [RFC v3] pciinit: setup mcfg for pxb-pcie to support multiple pci domains

2018-09-27 Thread Zihan Yang
HI Laszlo Laszlo Ersek 于2018年9月26日周三 上午1:17写道: > > On 09/25/18 17:38, Kevin O'Connor wrote: > > On Mon, Sep 17, 2018 at 11:02:59PM +0800, Zihan Yang wrote: > >> To support multiple pci domains of pxb-pcie device in qemu, we need to > >> setup > >> mcfg range in seabios. We use [0x8000,