[SeaBIOS] Re: [QEMU] [PATCH v2 0/8] Add Qemu to SeaBIOS LCHS interface

Hi, > Can there be a guest that will fail the MBR in such a way? Yes. > Look at the following MBR partition table of a Windows XP guest in our > production > environment: > > Disk size in sectors: 16777216 > > Binary (only one partition 16 bytes): 80 01 01 00 07 fe ff ff 3f 00 00 00 d5 > ea

[SeaBIOS] Re: [PATCH] scripts/buildversion.py: allow version to be overridden

On Thu, 2019-06-13 at 13:33 -0400, Kevin O'Connor wrote: > Can you give some background on how this is intended to be used? > > We used to allow the version string to be overridden, but we found the > results were a bit chaotic - different people chose different names > and it was hard to

[SeaBIOS] Re: [PATCH] scripts/buildversion.py: allow version to be overridden

On Thu, Jun 13, 2019 at 04:25:53PM +0100, David Woodhouse wrote: > Signed-off-by: David Woodhouse > --- > scripts/buildversion.py | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/scripts/buildversion.py b/scripts/buildversion.py > index 8875497..fc2decd 100755 > ---

[SeaBIOS] [PATCH] scripts/buildversion.py: allow version to be overridden

Signed-off-by: David Woodhouse --- scripts/buildversion.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/scripts/buildversion.py b/scripts/buildversion.py index 8875497..fc2decd 100755 --- a/scripts/buildversion.py +++ b/scripts/buildversion.py @@ -113,7 +113,9 @@ def

[SeaBIOS] [PATCH v2] csm: Sanitise alignment constraint in Legacy16GetTableAddress

The alignment constraint is defined in the CSM specifications as "Bit mapped. First non-zero bit from the right is the alignment." Use __fls() to sanitise the alignment given that definition, since passing a non-power-of-two alignment to _malloc() isn't going to work well. And cope with being

[SeaBIOS] Re: [PATCH] csm: Sanitise alignment constraint in Legacy16GetTableAddress

On Wed, Jun 12, 2019 at 05:56:23PM +0100, David Woodhouse wrote: > The alignment constraint is defined in the CSM specifications as > "Bit mapped. First non-zero bit from the right is the alignment." > > Use __fls() to sanitise the alignment given that definition, since > passing a

[SeaBIOS] Re: [QEMU] [PATCH v2 0/8] Add Qemu to SeaBIOS LCHS interface

> On 13 Jun 2019, at 12:38, Gerd Hoffmann wrote: > > Hi, > >> Yes they are pretty rare. >> Windows 2000 and Windows XP guests migrated from VMware to Qemu/KVM >> would not boot due to incorrect disk geometries (some had 32/56 spt instead >> of >> 56. Also number of heads was not entirely

[SeaBIOS] Re: [QEMU] [PATCH v2 0/8] Add Qemu to SeaBIOS LCHS interface

Hi, > Yes they are pretty rare. > Windows 2000 and Windows XP guests migrated from VMware to Qemu/KVM > would not boot due to incorrect disk geometries (some had 32/56 spt instead of > 56. Also number of heads was not entirely correct) Ok. > > Why? Asking the user to deal with the mess is

[SeaBIOS] Re: [QEMU] [PATCH v2 0/8] Add Qemu to SeaBIOS LCHS interface

typo: ddb.geometry.biosCylinders = “83257” * Sam > On 13 Jun 2019, at 10:41, Sam Eiderman wrote: > > > >> On 12 Jun 2019, at 22:18, Gerd Hoffmann > > wrote: >> >> On Wed, Jun 12, 2019 at 04:30:03PM +0300, Sam Eiderman wrote: >>> >>> On 12 Jun 2019, at 16:06,

[SeaBIOS] Re: [QEMU] [PATCH v2 0/8] Add Qemu to SeaBIOS LCHS interface

> On 12 Jun 2019, at 22:18, Gerd Hoffmann wrote: > > On Wed, Jun 12, 2019 at 04:30:03PM +0300, Sam Eiderman wrote: >> >> >>> On 12 Jun 2019, at 16:06, Gerd Hoffmann wrote: >>> >>> On Wed, Jun 12, 2019 at 02:59:31PM +0300, Sam Eiderman wrote: v1: Non-standard logical