[SeaBIOS] Re: [PATCH v7 7/8] bootdevice: FW_CFG interface for LCHS values

2019-09-26 Thread Philippe Mathieu-Daudé
On 9/26/19 9:09 PM, Philippe Mathieu-Daudé wrote: > On 9/26/19 8:26 PM, John Snow wrote: >> On 9/26/19 5:57 AM, Philippe Mathieu-Daudé wrote: >>> Hi Sam, >>> >>> On 9/25/19 1:06 PM, Sam Eiderman wrote: From: Sam Eiderman Using fw_cfg, supply logical CHS values directly from QEMU to

[SeaBIOS] Re: [PATCH v7 7/8] bootdevice: FW_CFG interface for LCHS values

2019-09-26 Thread Philippe Mathieu-Daudé
On 9/26/19 8:26 PM, John Snow wrote: > On 9/26/19 5:57 AM, Philippe Mathieu-Daudé wrote: >> Hi Sam, >> >> On 9/25/19 1:06 PM, Sam Eiderman wrote: >>> From: Sam Eiderman >>> >>> Using fw_cfg, supply logical CHS values directly from QEMU to the BIOS. >>> >>> Non-standard logical geometries break

[SeaBIOS] Re: [PATCH v7 7/8] bootdevice: FW_CFG interface for LCHS values

2019-09-26 Thread John Snow
On 9/26/19 5:57 AM, Philippe Mathieu-Daudé wrote: > Hi Sam, > > On 9/25/19 1:06 PM, Sam Eiderman wrote: >> From: Sam Eiderman >> >> Using fw_cfg, supply logical CHS values directly from QEMU to the BIOS. >> >> Non-standard logical geometries break under QEMU. >> >> A virtual disk which

[SeaBIOS] Re: [PATCH v7 8/8] hd-geo-test: Add tests for lchs override

2019-09-26 Thread John Snow
On 9/26/19 6:00 AM, Philippe Mathieu-Daudé wrote: > On 9/25/19 1:06 PM, Sam Eiderman wrote: >> From: Sam Eiderman >> >> Add QTest tests to check the logical geometry override option. >> >> The tests in hd-geo-test are out of date - they only test IDE and do not >> test interesting MBRs. >> >> I

[SeaBIOS] Re: [PATCH v7 8/8] hd-geo-test: Add tests for lchs override

2019-09-26 Thread Philippe Mathieu-Daudé
On 9/25/19 1:06 PM, Sam Eiderman wrote: > From: Sam Eiderman > > Add QTest tests to check the logical geometry override option. > > The tests in hd-geo-test are out of date - they only test IDE and do not > test interesting MBRs. > > I added a few helper functions which will make adding more

[SeaBIOS] Re: [PATCH v7 7/8] bootdevice: FW_CFG interface for LCHS values

2019-09-26 Thread Philippe Mathieu-Daudé
Hi Sam, On 9/25/19 1:06 PM, Sam Eiderman wrote: > From: Sam Eiderman > > Using fw_cfg, supply logical CHS values directly from QEMU to the BIOS. > > Non-standard logical geometries break under QEMU. > > A virtual disk which contains an operating system which depends on > logical geometries

[SeaBIOS] Re: [PATCH v7 6/8] bootdevice: Refactor get_boot_devices_list

2019-09-26 Thread Philippe Mathieu-Daudé
On 9/25/19 1:06 PM, Sam Eiderman wrote: > From: Sam Eiderman > > Move device name construction to a separate function. > > We will reuse this function in the following commit to pass logical CHS > parameters through fw_cfg much like we currently pass bootindex. > > Reviewed-by: Karl Heubaum >

[SeaBIOS] Re: [PATCH v7 4/8] scsi: Propagate unrealize() callback to scsi-hd

2019-09-26 Thread Philippe Mathieu-Daudé
On 9/25/19 1:06 PM, Sam Eiderman wrote: > From: Sam Eiderman > > We will need to add LCHS removal logic to scsi-hd's unrealize() in the > next commit. > > Signed-off-by: Sam Eiderman > Reviewed-by: Karl Heubaum > Reviewed-by: Arbel Moshe > Signed-off-by: Sam Eiderman Reviewed-by: Philippe

[SeaBIOS] Re: [PATCH v7 1/8] block: Refactor macros - fix tabbing

2019-09-26 Thread Philippe Mathieu-Daudé
On 9/25/19 1:06 PM, Sam Eiderman wrote: > From: Sam Eiderman > > Fixing tabbing in block related macros. > > Reviewed-by: Karl Heubaum > Reviewed-by: Arbel Moshe > Signed-off-by: Sam Eiderman Reviewed-by: Philippe Mathieu-Daudé > --- > hw/ide/qdev.c| 2 +- >