[SeaBIOS] Re: [PATCH v2 1/2] cbvga: reuse svga modes definitions from svgamodes.c

2019-10-17 Thread Uwe Kleine-König
Hello, On 10/17/19 10:33 PM, Uwe Kleine-König wrote: > For cbvga only modes with MM_DIRECT are usable, so skip the other ones. > This effectively adds the following modes: > > { 0x10D, { MM_DIRECT, 320, 200, 15, 8, 16, SEG_GRAPH } }, > { 0x10E, { MM_DIRECT, 320, 200, 16, 8, 16, SEG_GR

[SeaBIOS] [PATCH v2 2/2] Add additional resolutions for 16:9 displays: 1600x900 and 2560x1440

2019-10-17 Thread Uwe Kleine-König
This allows to have qemu run at the native screen resolution of my (physical) monitor. This is inspired by a patch created by Andreas Dangel that I found on https://adangel.org/2015/09/11/qemu-kvm-custom-resolutions/ . Signed-off-by: Uwe Kleine-König --- vgasrc/svgamodes.c | 8 1 file

[SeaBIOS] [PATCH v2 1/2] cbvga: reuse svga modes definitions from svgamodes.c

2019-10-17 Thread Uwe Kleine-König
For cbvga only modes with MM_DIRECT are usable, so skip the other ones. This effectively adds the following modes: { 0x10D, { MM_DIRECT, 320, 200, 15, 8, 16, SEG_GRAPH } }, { 0x10E, { MM_DIRECT, 320, 200, 16, 8, 16, SEG_GRAPH } }, { 0x10F, { MM_DIRECT, 320, 200, 24, 8, 16, SEG_GR

[SeaBIOS] Re: [PATCH v3 0/2] Add additional resolutions for 16:9 displays: 1600x900 and 2560x1440

2019-10-17 Thread Matt DeVillier
'signed-off-by' is a linux kernel convention; by adding your Signed-off-by line to a patch, you are certifying that you have read and understood the Developer Certificate of Origin (DCO), originated in 2004 by the Linux foundation as an affirmation that the source code being submitted originated fr

[SeaBIOS] Re: [PATCH v3 0/2] Add additional resolutions for 16:9 displays: 1600x900 and 2560x1440

2019-10-17 Thread Uwe Kleine-König
On 10/17/19 10:51 AM, Gerd Hoffmann wrote: > On Thu, Oct 17, 2019 at 09:44:38AM +0200, Uwe Kleine-König wrote: >> I'm still unclear about that >> Signed-of-by concern. > > Re-send patches with Signed-of-by added to the commit message. Git can > do that automatically for you (-s switch for "git co

[SeaBIOS] Re: [PATCH v3 0/2] Add additional resolutions for 16:9 displays: 1600x900 and 2560x1440

2019-10-17 Thread Gerd Hoffmann
On Thu, Oct 17, 2019 at 09:44:38AM +0200, Uwe Kleine-König wrote: > On 10/16/19 12:27 PM, Gerd Hoffmann wrote: > > On Sat, Oct 12, 2019 at 10:07:23PM -0400, Kevin O'Connor wrote: > >> On Thu, Oct 10, 2019 at 05:43:30PM +0200, Uwe Kleine-König wrote: > >>> On 7/31/19 5:51 PM, Uwe Kleine-König wrote:

[SeaBIOS] Re: [PATCH v3 0/2] Add additional resolutions for 16:9 displays: 1600x900 and 2560x1440

2019-10-17 Thread Uwe Kleine-König
On 10/16/19 12:27 PM, Gerd Hoffmann wrote: > On Sat, Oct 12, 2019 at 10:07:23PM -0400, Kevin O'Connor wrote: >> On Thu, Oct 10, 2019 at 05:43:30PM +0200, Uwe Kleine-König wrote: >>> On 7/31/19 5:51 PM, Uwe Kleine-König wrote: Hello, this is my attempt to address the review comments I