[SeaBIOS] new release tag?

2023-08-07 Thread Niklas Cassel via SeaBIOS
Hello Seabios maintainers, I was wondering, is there any chance of getting a new release tag (e.g. rel-1.16.3) anytime soon? Or is there any plan on when it will be tagged? I'm waiting to send out a (AHCI specific) QEMU patch, but I can't do so until: 1) there is a new Seabios tag 2) QEMU has

[SeaBIOS] [PATCH v3 3/3] esp-scsi: handle non-DMA SCSI commands with no data phase

2023-08-07 Thread Mark Cave-Ayland
The existing esp-scsi state machine checks for the STAT_TC bit to exit state 1 but in the case where there is no data phase, a non-DMA command is executed which doesn't set STAT_TC. This only works because QEMU currently always sets STAT_TC just after issuing every SCSI command. Update the

[SeaBIOS] [PATCH v3 2/3] esp-scsi: check for INTR_BS/INTR_FC instead of STAT_TC for command completion

2023-08-07 Thread Mark Cave-Ayland
The ESP SELATN command used to send SCSI commands from the ESP to the SCSI bus is not a DMA command and therefore does not affect the STAT_TC bit. The only reason this works at all is due to a bug in QEMU which (currently) always updates the STAT_TC bit in ESP_RSTAT regardless of the state of the

[SeaBIOS] [PATCH v3 1/3] esp-scsi: flush FIFO before sending SCSI command

2023-08-07 Thread Mark Cave-Ayland
The ESP FIFO is used as a buffer for DMA requests and so isn't guaranteed to be empty in the case of SCSI errors or a mixed DMA/non-DMA request. Flush the FIFO before sending a SCSI command to guarantee that it is correctly positioned at the start of the FIFO. Signed-off-by: Mark Cave-Ayland

[SeaBIOS] [PATCH v3 0/3] esp-scsi: fix reliance on QEMU ESP SCSI implementation bugs

2023-08-07 Thread Mark Cave-Ayland
Whilst trying to improve QEMU's ESP SCSI implementation with regard to the NCR datasheet, I noticed that SeaBIOS would fail to boot one of my Debian test images with my patches applied. Further investigation revealed that the SeaBIOS esp-scsi driver inadvertently relies on existing bugs in QEMU's

[SeaBIOS] Re: [PATCH v2 0/2] esp-scsi: fix reliance on QEMU ESP SCSI implementation bugs

2023-08-07 Thread Mark Cave-Ayland
On 02/08/2023 10:48, Mark Cave-Ayland wrote: Whilst trying to improve QEMU's ESP SCSI implementation with regard to the NCR datasheet, I noticed that SeaBIOS would fail to boot one of my Debian test images with my patches applied. Further investigation revealed that the SeaBIOS esp-scsi driver