Re: [SeaBIOS] [PATCH] Support for booting from LSI Logic LSI53C1030, SAS1068, SAS1068e

2016-01-27 Thread Kevin O'Connor
On Wed, Jan 27, 2016 at 03:51:02PM +0100, Paolo Bonzini wrote: > From: Don Slutz > > Also known as Fusion MPT disk; this controller model is supported > by VirtualBox and VMware, and QEMU support patches have been > posted. > > Signed-off-by: Don Slutz

Re: [SeaBIOS] [PATCH] Support for booting from LSI Logic LSI53C1030, SAS1068, SAS1068e

2016-01-27 Thread Paolo Bonzini
On 27/01/2016 16:57, Kevin O'Connor wrote: > On Wed, Jan 27, 2016 at 03:51:02PM +0100, Paolo Bonzini wrote: >> From: Don Slutz >> >> Also known as Fusion MPT disk; this controller model is supported >> by VirtualBox and VMware, and QEMU support patches have been >> posted.

Re: [SeaBIOS] [PATCH] Support for booting from LSI Logic LSI53C1030, SAS1068, SAS1068e

2016-01-27 Thread Timothy Pearson
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 01/27/2016 10:38 AM, Paolo Bonzini wrote: > > > On 27/01/2016 16:57, Kevin O'Connor wrote: >> On Wed, Jan 27, 2016 at 03:51:02PM +0100, Paolo Bonzini wrote: >>> From: Don Slutz >>> >>> Also known as Fusion MPT disk; this

Re: [SeaBIOS] [PATCH] Support for booting from LSI Logic LSI53C1030, SAS1068, SAS1068e

2016-01-27 Thread Kevin O'Connor
On Wed, Jan 27, 2016 at 10:45:13AM -0600, Timothy Pearson wrote: > On 01/27/2016 10:38 AM, Paolo Bonzini wrote: > > On 27/01/2016 16:57, Kevin O'Connor wrote: > >> On Wed, Jan 27, 2016 at 03:51:02PM +0100, Paolo Bonzini wrote: > >>> --- a/src/Kconfig > >>> +++ b/src/Kconfig > >>> @@ -208,6 +208,12

Re: [SeaBIOS] [PATCH] Support for booting from LSI Logic LSI53C1030, SAS1068, SAS1068e

2016-01-27 Thread Paolo Bonzini
On 27/01/2016 18:15, Kevin O'Connor wrote: > Oh, I understand and agree that recovery isn't worth while. My > concern is that a hardware error here will appear as a silent hang. > Breaking out of the loop eventually, calling warn_timeout(), and > returning an error code has the benefit of some

Re: [SeaBIOS] [PATCH] Support for booting from LSI Logic LSI53C1030, SAS1068, SAS1068e

2016-01-27 Thread Kevin O'Connor
On Wed, Jan 27, 2016 at 06:19:43PM +0100, Paolo Bonzini wrote: > On 27/01/2016 18:15, Kevin O'Connor wrote: > > Oh, I understand and agree that recovery isn't worth while. My > > concern is that a hardware error here will appear as a silent hang. > > Breaking out of the loop eventually, calling

Re: [SeaBIOS] [PATCH] Support for booting from LSI Logic LSI53C1030, SAS1068, SAS1068e

2016-01-27 Thread Paolo Bonzini
On 27/01/2016 18:55, Kevin O'Connor wrote: > Most of the SeaBIOS drivers do implement timeouts. I think the only > ones that don't are lsi-scsi, pvscsi, and virtio. > > The timeout should come from the hardware spec - a lot of specs do > list a maximum transaction time. (It's also possible

Re: [SeaBIOS] [PATCH] Support for booting from LSI Logic LSI53C1030, SAS1068, SAS1068e

2016-01-27 Thread Paolo Bonzini
On 27/01/2016 18:30, Kevin O'Connor wrote: > On Wed, Jan 27, 2016 at 06:19:43PM +0100, Paolo Bonzini wrote: >> On 27/01/2016 18:15, Kevin O'Connor wrote: >>> Oh, I understand and agree that recovery isn't worth while. My >>> concern is that a hardware error here will appear as a silent hang.

[SeaBIOS] [PATCH] Support for booting from LSI Logic LSI53C1030, SAS1068, SAS1068e

2016-01-27 Thread Paolo Bonzini
From: Don Slutz Also known as Fusion MPT disk; this controller model is supported by VirtualBox and VMware, and QEMU support patches have been posted. Signed-off-by: Don Slutz Signed-off-by: Paolo Bonzini --- Makefile |