Re: [SeaBIOS] [PATCH 0/7] vgabios improvements

2014-05-19 Thread David Woodhouse
On Wed, 2014-04-16 at 12:37 -0400, Kevin O'Connor wrote: On Mon, Apr 14, 2014 at 02:22:51PM +0200, Gerd Hoffmann wrote: So you can try this: qemu -vga std -bios /usr/share/coreboot.git/coreboot-i440fx-seabios.rom to see it live in action. Two problems spotted so far: (1)

Re: [SeaBIOS] [PATCH 0/7] vgabios improvements

2014-05-19 Thread Kevin O'Connor
On Mon, May 19, 2014 at 08:23:25PM +0100, David Woodhouse wrote: On Wed, 2014-04-16 at 12:37 -0400, Kevin O'Connor wrote: This is unfortunate. I can put a hack into seabios (not seavgabios) to use bigreal mode for int 1587 calls during option rom execution. But, it does raise the question

Re: [SeaBIOS] [PATCH 0/7] vgabios improvements

2014-04-18 Thread H. Peter Anvin
On 04/17/2014 01:41 AM, Gerd Hoffmann wrote: On Mi, 2014-04-16 at 17:30 -0700, H. Peter Anvin wrote: Syslinux currently looks for a 640x480 mode unless MENU RESOLUTION is given. Do the vgabios interfaces allow for bytes_per_line being different from x_res * bytes_per_pixel? If so seavgabios

Re: [SeaBIOS] [PATCH 0/7] vgabios improvements

2014-04-17 Thread H. Peter Anvin
It does. On the other hand, Syslinux really need to handle various resolutions better. Unto recently, though, 640x480 was universally available. On April 17, 2014 1:41:58 AM PDT, Gerd Hoffmann kra...@redhat.com wrote: On Mi, 2014-04-16 at 17:30 -0700, H. Peter Anvin wrote: Syslinux currently

Re: [SeaBIOS] [PATCH 0/7] vgabios improvements

2014-04-16 Thread Kevin O'Connor
On Tue, Apr 15, 2014 at 07:52:47AM +0200, Gerd Hoffmann wrote: Hi, Oddly, I can't boot from a hard drive (-hda) when I use the coreboot/seabios I built though. It keeps failing at Booting from Hard Disk I see that with my builds too, but only with -vga std (where coreboot

Re: [SeaBIOS] [PATCH 0/7] vgabios improvements

2014-04-16 Thread Gerd Hoffmann
Hi, --- a/src/hw/ata.c +++ b/src/hw/ata.c -pci_config_maskw(bdf, PCI_COMMAND, 0, PCI_COMMAND_MASTER); +pci_config_maskw(bdf, PCI_COMMAND, 0, PCI_COMMAND_MASTER | PCI_COMMAND_IO | PCI_COMMAND_MEMORY); Ah. I think that should go in. If we need it, we better make

Re: [SeaBIOS] [PATCH 0/7] vgabios improvements

2014-04-16 Thread Kevin O'Connor
On Wed, Apr 16, 2014 at 06:17:45PM +0200, Gerd Hoffmann wrote: Hi, --- a/src/hw/ata.c +++ b/src/hw/ata.c -pci_config_maskw(bdf, PCI_COMMAND, 0, PCI_COMMAND_MASTER); +pci_config_maskw(bdf, PCI_COMMAND, 0, PCI_COMMAND_MASTER | PCI_COMMAND_IO |

Re: [SeaBIOS] [PATCH 0/7] vgabios improvements

2014-04-16 Thread Kevin O'Connor
On Mon, Apr 14, 2014 at 02:22:51PM +0200, Gerd Hoffmann wrote: So you can try this: qemu -vga std -bios /usr/share/coreboot.git/coreboot-i440fx-seabios.rom to see it live in action. Two problems spotted so far: (1) ipxe hangs at rom load time. can be worked around by adding

Re: [SeaBIOS] [PATCH 0/7] vgabios improvements

2014-04-16 Thread Gerd Hoffmann
Hi, That said, CONFIG_ATA_DMA is very fragile and it may be worth just removing at some point. Why is it fragile? cheers, Gerd ___ SeaBIOS mailing list SeaBIOS@seabios.org http://www.seabios.org/mailman/listinfo/seabios

Re: [SeaBIOS] [PATCH 0/7] vgabios improvements

2014-04-16 Thread Gerd Hoffmann
Hi, But, it does raise the question of how many other callers expect the bios to not mess with the segment limits. (Though, to be honest, the only goal I have with coreboot native seavgabios is support for grub, lilo, syslinux, and maybe ntldr.) Yes, it should be good enough for

Re: [SeaBIOS] [PATCH 0/7] vgabios improvements

2014-04-16 Thread Gerd Hoffmann
Hi, But, it does raise the question of how many other callers expect the bios to not mess with the segment limits. (Though, to be honest, the only goal I have with coreboot native seavgabios is support for grub, lilo, syslinux, and maybe ntldr.) Yes, it should be good enough for

Re: [SeaBIOS] [PATCH 0/7] vgabios improvements

2014-04-16 Thread Kevin O'Connor
On Wed, Apr 16, 2014 at 06:48:43PM +0200, Gerd Hoffmann wrote: Hi, That said, CONFIG_ATA_DMA is very fragile and it may be worth just removing at some point. Why is it fragile? On PATA you're supposed to do all these weird controller specific stuff to make sure DMA works, to set

Re: [SeaBIOS] [PATCH 0/7] vgabios improvements

2014-04-16 Thread Kevin O'Connor
On Wed, Apr 16, 2014 at 06:56:57PM +0200, Gerd Hoffmann wrote: And we don't have a cursor I've noticed meanwhile. That would be very helpful for editing your linux cmd line in the boot loader. A blinking cursor is probably a bit unrealistic (need timer interrupt etc), but emulating a block

Re: [SeaBIOS] [PATCH 0/7] vgabios improvements

2014-04-16 Thread Kevin O'Connor
On Wed, Apr 16, 2014 at 06:56:57PM +0200, Gerd Hoffmann wrote: Emulating attributes would be great so you can actually navigate bootloader menus. I took a look a closer look at this. Some things I found: - it looks like the syslinux menu on recent Fedora versions doesn't work correctly at

Re: [SeaBIOS] [PATCH 0/7] vgabios improvements

2014-04-16 Thread H. Peter Anvin
On 04/16/2014 04:21 PM, Kevin O'Connor wrote: On Wed, Apr 16, 2014 at 04:00:07PM -0700, H. Peter Anvin wrote: On 04/16/2014 03:47 PM, Kevin O'Connor wrote: On Wed, Apr 16, 2014 at 06:56:57PM +0200, Gerd Hoffmann wrote: Emulating attributes would be great so you can actually navigate

Re: [SeaBIOS] [PATCH 0/7] vgabios improvements

2014-04-16 Thread H. Peter Anvin
On 04/16/2014 03:47 PM, Kevin O'Connor wrote: On Wed, Apr 16, 2014 at 06:56:57PM +0200, Gerd Hoffmann wrote: Emulating attributes would be great so you can actually navigate bootloader menus. I took a look a closer look at this. Some things I found: - it looks like the syslinux menu on

Re: [SeaBIOS] [PATCH 0/7] vgabios improvements

2014-04-16 Thread Peter Stuge
H. Peter Anvin wrote: Uh... seriously, robustness is a good thing, and it is not entirely clear that this responsibility necessarily belongs in Coreboot. It's clear to me. The coreboot (all lowercase please) code for QEMU isn't neccessarily complete, and needs these kinds of improvements.

Re: [SeaBIOS] [PATCH 0/7] vgabios improvements

2014-04-16 Thread H. Peter Anvin
Syslinux currently looks for a 640x480 mode unless MENU RESOLUTION is given. On April 16, 2014 5:12:21 PM PDT, Kevin O'Connor ke...@koconnor.net wrote: On Wed, Apr 16, 2014 at 04:25:48PM -0700, H. Peter Anvin wrote: On 04/16/2014 04:21 PM, Kevin O'Connor wrote: If I build SeaVGABIOS without

Re: [SeaBIOS] [PATCH 0/7] vgabios improvements

2014-04-14 Thread Gerd Hoffmann
On Fr, 2014-04-11 at 11:31 -0400, Kevin O'Connor wrote: On Sun, Apr 06, 2014 at 06:59:53PM -0400, Kevin O'Connor wrote: This patch series refactors the vgabios graphics mode framebuffer manipulation code. It then adds in support for manipulating direct framebuffers that modern vga modes

Re: [SeaBIOS] [PATCH 0/7] vgabios improvements

2014-04-14 Thread Gerd Hoffmann
On Fr, 2014-04-11 at 11:31 -0400, Kevin O'Connor wrote: On Sun, Apr 06, 2014 at 06:59:53PM -0400, Kevin O'Connor wrote: This patch series refactors the vgabios graphics mode framebuffer manipulation code. It then adds in support for manipulating direct framebuffers that modern vga modes

Re: [SeaBIOS] [PATCH 0/7] vgabios improvements

2014-04-14 Thread Kevin O'Connor
On Mon, Apr 14, 2014 at 11:59:13AM +0200, Gerd Hoffmann wrote: On Fr, 2014-04-11 at 11:31 -0400, Kevin O'Connor wrote: On Sun, Apr 06, 2014 at 06:59:53PM -0400, Kevin O'Connor wrote: This patch series refactors the vgabios graphics mode framebuffer manipulation code. It then adds in

Re: [SeaBIOS] [PATCH 0/7] vgabios improvements

2014-04-14 Thread Kevin O'Connor
On Mon, Apr 14, 2014 at 02:22:51PM +0200, Gerd Hoffmann wrote: So you can try this: qemu -vga std -bios /usr/share/coreboot.git/coreboot-i440fx-seabios.rom to see it live in action. Two problems spotted so far: (1) ipxe hangs at rom load time. can be worked around by adding

Re: [SeaBIOS] [PATCH 0/7] vgabios improvements

2014-04-14 Thread Gerd Hoffmann
Hi, Thanks. Looks like that set of options would have broken the build even prior to the vga patch series. There was no reason to try though ;) I can fix the compilation with the patch below, but it wont actually permit the vgabios to use the debug_io support. Reasonable. cheers,

Re: [SeaBIOS] [PATCH 0/7] vgabios improvements

2014-04-14 Thread Gerd Hoffmann
Hi, Oddly, I can't boot from a hard drive (-hda) when I use the coreboot/seabios I built though. It keeps failing at Booting from Hard Disk I see that with my builds too, but only with -vga std (where coreboot vgabios is used). Same bios image with -vga cirrus works fine. So it seems

[SeaBIOS] [PATCH 0/7] vgabios improvements

2014-04-06 Thread Kevin O'Connor
This patch series refactors the vgabios graphics mode framebuffer manipulation code. It then adds in support for manipulating direct framebuffers that modern vga modes use. This series (along with the followup patches for coreboot native vga vgabios) is also available at: