Hi Gerd,
On 8/24/2018 4:24 PM, Gerd Hoffmann wrote:
I imagine you'd post v3 with the update Gerd requested for the debug
level(s), and then I'd respond with my R-b. (Obviously I'm not a SeaBIOS
maintainer so that'll not be "decisive" by any means.)
Oh, BTW, I am considering, if only dismatch
> > I imagine you'd post v3 with the update Gerd requested for the debug
> > level(s), and then I'd respond with my R-b. (Obviously I'm not a SeaBIOS
> > maintainer so that'll not be "decisive" by any means.)
> >
> Oh, BTW, I am considering, if only dismatch vendor-id stands for
> "non-qemu
On 8/24/2018 4:02 PM, Laszlo Ersek wrote:
On 08/24/18 09:48, Liu, Jing2 wrote:
[...]
+ if (pci_config_readw(bdf, PCI_VENDOR_ID) !=
PCI_VENDOR_ID_REDHAT) {
+ dprintf(1, "PCI: QEMU resource reserve cap vendor ID
doesn't
match.\n");
I'd suggest to use a higher debug level for this
On 08/24/18 09:48, Liu, Jing2 wrote:
>
>
> On 8/24/2018 3:12 PM, Laszlo Ersek wrote:
>> On 08/24/18 04:23, Liu, Jing2 wrote:
>>> Hi Laszlo,
>>>
>>> On 8/22/2018 5:13 PM, Laszlo Ersek wrote:
On 08/16/18 12:43, Liu, Jing2 wrote:
>
>
> On 8/16/2018 3:18 PM, Gerd Hoffmann wrote:
On 8/24/2018 3:12 PM, Laszlo Ersek wrote:
On 08/24/18 04:23, Liu, Jing2 wrote:
Hi Laszlo,
On 8/22/2018 5:13 PM, Laszlo Ersek wrote:
On 08/16/18 12:43, Liu, Jing2 wrote:
On 8/16/2018 3:18 PM, Gerd Hoffmann wrote:
Hi,
+ if (pci_config_readw(bdf, PCI_VENDOR_ID) !=
On Fri, Aug 24, 2018 at 09:12:47AM +0200, Laszlo Ersek wrote:
> On 08/24/18 04:23, Liu, Jing2 wrote:
> > Hi Laszlo,
> >
> > On 8/22/2018 5:13 PM, Laszlo Ersek wrote:
> >> On 08/16/18 12:43, Liu, Jing2 wrote:
> >>>
> >>>
> >>> On 8/16/2018 3:18 PM, Gerd Hoffmann wrote:
> Hi,
>
>
On 8/24/2018 3:12 PM, Laszlo Ersek wrote:
On 08/24/18 04:23, Liu, Jing2 wrote:
Hi Laszlo,
On 8/22/2018 5:13 PM, Laszlo Ersek wrote:
On 08/16/18 12:43, Liu, Jing2 wrote:
On 8/16/2018 3:18 PM, Gerd Hoffmann wrote:
Hi,
+ if (pci_config_readw(bdf, PCI_VENDOR_ID) !=
On 08/24/18 04:23, Liu, Jing2 wrote:
> Hi Laszlo,
>
> On 8/22/2018 5:13 PM, Laszlo Ersek wrote:
>> On 08/16/18 12:43, Liu, Jing2 wrote:
>>>
>>>
>>> On 8/16/2018 3:18 PM, Gerd Hoffmann wrote:
Hi,
> + if (pci_config_readw(bdf, PCI_VENDOR_ID) !=
> PCI_VENDOR_ID_REDHAT) {
Hi Laszlo,
On 8/22/2018 5:13 PM, Laszlo Ersek wrote:
On 08/16/18 12:43, Liu, Jing2 wrote:
On 8/16/2018 3:18 PM, Gerd Hoffmann wrote:
Hi,
+ if (pci_config_readw(bdf, PCI_VENDOR_ID) != PCI_VENDOR_ID_REDHAT) {
+ dprintf(1, "PCI: QEMU resource reserve cap vendor ID doesn't
On 08/16/18 12:43, Liu, Jing2 wrote:
>
>
> On 8/16/2018 3:18 PM, Gerd Hoffmann wrote:
>> Hi,
>>
>>> + if (pci_config_readw(bdf, PCI_VENDOR_ID) != PCI_VENDOR_ID_REDHAT) {
>>> + dprintf(1, "PCI: QEMU resource reserve cap vendor ID doesn't
>>> match.\n");
>>
>> I'd suggest to use a
On 8/16/2018 9:10 PM, Gerd Hoffmann wrote:
On Thu, Aug 16, 2018 at 05:30:45PM +0800, Liu, Jing2 wrote:
Hi Gerd,
On 8/16/2018 3:19 PM, Gerd Hoffmann wrote:
Hi,
I think PCI_DEVICE_ID_REDHAT_PCIE_BRIDGE shoud be added too, in case we put
a pcie_pci_bridge at the host bus.
Yes, please.
On Thu, Aug 16, 2018 at 05:30:45PM +0800, Liu, Jing2 wrote:
> Hi Gerd,
>
> On 8/16/2018 3:19 PM, Gerd Hoffmann wrote:
> >Hi,
> >
> > > I think PCI_DEVICE_ID_REDHAT_PCIE_BRIDGE shoud be added too, in case we
> > > put
> > > a pcie_pci_bridge at the host bus.
> >
> > Yes, please.
> Thanks
On 8/16/2018 3:18 PM, Gerd Hoffmann wrote:
Hi,
+if (pci_config_readw(bdf, PCI_VENDOR_ID) != PCI_VENDOR_ID_REDHAT) {
+dprintf(1, "PCI: QEMU resource reserve cap vendor ID doesn't
match.\n");
I'd suggest to use a higher debug level for this one, 3 would be a good
pick I
Hi Gerd,
On 8/16/2018 3:19 PM, Gerd Hoffmann wrote:
Hi,
I think PCI_DEVICE_ID_REDHAT_PCIE_BRIDGE shoud be added too, in case we put
a pcie_pci_bridge at the host bus.
Yes, please.
Thanks for comments. Sure, can be added simply. While this bridge
doesn't have resource reserve capability
Hi,
> I think PCI_DEVICE_ID_REDHAT_PCIE_BRIDGE shoud be added too, in case we put
> a pcie_pci_bridge at the host bus.
Yes, please.
thanks,
Gerd
___
SeaBIOS mailing list
SeaBIOS@seabios.org
https://mail.coreboot.org/mailman/listinfo/seabios
Hi,
> +if (pci_config_readw(bdf, PCI_VENDOR_ID) != PCI_VENDOR_ID_REDHAT) {
> +dprintf(1, "PCI: QEMU resource reserve cap vendor ID doesn't
> match.\n");
I'd suggest to use a higher debug level for this one, 3 would be a good
pick I think. level 1 messages are printed by default,
On 8/16/2018 1:06 PM, Zihan Yang wrote:
Liu, Jing2 于2018年8月16日周四 上午10:39写道：
Hi Zihan,
I copy your comments of this patch several days ago here,
and hope we could continue some discussion in this serial.
Hi Jing,
Sorry for the delay. I tested at the code just now and find that pcie
Liu, Jing2 于2018年8月16日周四 上午10:39写道：
>
> Hi Zihan,
>
> I copy your comments of this patch several days ago here,
> and hope we could continue some discussion in this serial.
Hi Jing,
Sorry for the delay. I tested at the code just now and find that pcie
bridge does not
use a vendor specific
Hi Zihan,
I copy your comments of this patch several days ago here,
and hope we could continue some discussion in this serial.
On 8/16/2018 10:32 AM, Jing Liu wrote:
[...]
static u8 pci_find_resource_reserve_capability(u16 bdf)
{
-if (pci_config_readw(bdf, PCI_VENDOR_ID) ==
On 8/13/2018 7:54 PM, Zihan Yang wrote:
Enable the firmware recognizing RedHat legacy PCI bridge device ID,
so QEMU can reserve additional PCI bridge resource capability.
Signed-off-by: Jing Liu
---
src/fw/pciinit.c | 50 +-
> Enable the firmware recognizing RedHat legacy PCI bridge device ID,
> so QEMU can reserve additional PCI bridge resource capability.
>
> Signed-off-by: Jing Liu
> ---
> src/fw/pciinit.c | 50 +-
> src/hw/pci_ids.h | 1 +
> 2 files changed, 30
Enable the firmware recognizing RedHat legacy PCI bridge device ID,
so QEMU can reserve additional PCI bridge resource capability.
Signed-off-by: Jing Liu
---
src/fw/pciinit.c | 50 +-
src/hw/pci_ids.h | 1 +
2 files changed, 30 insertions(+), 21
22 matches
Mail list logo
