[SeaBIOS] Re: [PATCH] MP: fix mptable interrupt source generation for pci devices

2022-04-22 Thread Rudolf Marek
Hi, On 20. 04. 22 15:18, Igor Mammedov wrote: relevant discussion https://lists.gnu.org/archive/html/qemu-devel/2022-01/msg04271.html gist: legacy tables aren't maintained nor really tested and subject to break without notice, add ACPI support to pet OS if possible (RSTD lookup and

[SeaBIOS] Re: [PATCH] MP: fix mptable interrupt source generation for pci devices

2022-04-20 Thread Igor Mammedov
On Wed, 20 Apr 2022 13:32:33 +0200 Paul Menzel wrote: > Dear Igor, dear Kevin, dear Gerd, > > > Am 20.04.22 um 11:14 schrieb Igor Mammedov: > > On Tue, 19 Apr 2022 09:52:42 -0400 Kevin O'Connor wrote: > > > >> On Tue, Apr 19, 2022 at 11:46:59AM +0200, Gerd Hoffmann wrote: > > diff

[SeaBIOS] Re: [PATCH] MP: fix mptable interrupt source generation for pci devices

2022-04-20 Thread Paul Menzel
Dear Igor, dear Kevin, dear Gerd, Am 20.04.22 um 11:14 schrieb Igor Mammedov: On Tue, 19 Apr 2022 09:52:42 -0400 Kevin O'Connor wrote: On Tue, Apr 19, 2022 at 11:46:59AM +0200, Gerd Hoffmann wrote: diff --git a/src/fw/mptable.c b/src/fw/mptable.c index 47385cc..3a7b02f 100644 ---

[SeaBIOS] Re: [PATCH] MP: fix mptable interrupt source generation for pci devices

2022-04-20 Thread Igor Mammedov
On Tue, 19 Apr 2022 09:52:42 -0400 Kevin O'Connor wrote: > On Tue, Apr 19, 2022 at 11:46:59AM +0200, Gerd Hoffmann wrote: > > > > diff --git a/src/fw/mptable.c b/src/fw/mptable.c > > > > index 47385cc..3a7b02f 100644 > > > > --- a/src/fw/mptable.c > > > > +++ b/src/fw/mptable.c > > > > > > If

[SeaBIOS] Re: [PATCH] MP: fix mptable interrupt source generation for pci devices

2022-04-19 Thread Kevin O'Connor
On Tue, Apr 19, 2022 at 11:46:59AM +0200, Gerd Hoffmann wrote: > > > diff --git a/src/fw/mptable.c b/src/fw/mptable.c > > > index 47385cc..3a7b02f 100644 > > > --- a/src/fw/mptable.c > > > +++ b/src/fw/mptable.c > > > > If you look at the top of that file you'll see the notice: > > > > // DO NOT

[SeaBIOS] Re: [PATCH] MP: fix mptable interrupt source generation for pci devices

2022-04-19 Thread Gerd Hoffmann
> > diff --git a/src/fw/mptable.c b/src/fw/mptable.c > > index 47385cc..3a7b02f 100644 > > --- a/src/fw/mptable.c > > +++ b/src/fw/mptable.c > > If you look at the top of that file you'll see the notice: > > // DO NOT ADD NEW FEATURES HERE. (See paravirt.c / biostables.c instead.) > > The

[SeaBIOS] Re: [PATCH] MP: fix mptable interrupt source generation for pci devices

2022-04-15 Thread Jay Khandkar
On Fri, Apr 15, 2022 at 11:50:15AM -0400, Kevin O'Connor wrote: > On Fri, Apr 15, 2022 at 04:33:34PM +0530, Jay Khandkar wrote: > > Set the correct IOAPIC INTIN pin number for pci bus interrupt > > sources during MP spec table generation (on emulators). Currently, > > the pin number is set to the

[SeaBIOS] Re: [PATCH] MP: fix mptable interrupt source generation for pci devices

2022-04-15 Thread Kevin O'Connor
On Fri, Apr 15, 2022 at 04:33:34PM +0530, Jay Khandkar wrote: > Set the correct IOAPIC INTIN pin number for pci bus interrupt > sources during MP spec table generation (on emulators). Currently, > the pin number is set to the interrupt line field in the device's > configuration space, which is set