[SeaBIOS] Re: [PATCH] nvme: fix LBA format data structure

2022-02-03 Thread Kevin O'Connor
On Sun, Jan 23, 2022 at 05:43:57PM +0100, Florian Larysch wrote: > The LBA Format Data structure is dword-sized, but struct nvme_lba_format > erroneously contains an additional member, misaligning all LBAF > descriptors after the first and causing them to be misinterpreted. > Remove it. Thanks.

[SeaBIOS] Re: [PATCH] nvme: fix LBA format data structure

2022-02-02 Thread Alexander Graf via SeaBIOS
On 02.02.22 16:24, Kevin O'Connor wrote: On Wed, Feb 02, 2022 at 11:50:50AM +0100, Alexander Graf wrote: On 02.02.22 02:52, Kevin O'Connor wrote: On Tue, Feb 01, 2022 at 08:39:10PM +0100, Florian Larysch wrote: On Thu, Jan 27, 2022 at 11:37:52AM -0500, Kevin O'Connor wrote: Thanks. I

[SeaBIOS] Re: [PATCH] nvme: fix LBA format data structure

2022-02-02 Thread Kevin O'Connor
On Wed, Feb 02, 2022 at 11:50:50AM +0100, Alexander Graf wrote: > > On 02.02.22 02:52, Kevin O'Connor wrote: > > On Tue, Feb 01, 2022 at 08:39:10PM +0100, Florian Larysch wrote: > > > On Thu, Jan 27, 2022 at 11:37:52AM -0500, Kevin O'Connor wrote: > > > > Thanks. I don't know enough about NVMe

[SeaBIOS] Re: [PATCH] nvme: fix LBA format data structure

2022-02-02 Thread Alexander Graf via SeaBIOS
On 02.02.22 02:52, Kevin O'Connor wrote: On Tue, Feb 01, 2022 at 08:39:10PM +0100, Florian Larysch wrote: On Thu, Jan 27, 2022 at 11:37:52AM -0500, Kevin O'Connor wrote: Thanks. I don't know enough about NVMe to review this patch though. Maybe Julian or Alex could comment? Happy to hear

[SeaBIOS] Re: [PATCH] nvme: fix LBA format data structure

2022-02-01 Thread Kevin O'Connor
On Tue, Feb 01, 2022 at 08:39:10PM +0100, Florian Larysch wrote: > On Thu, Jan 27, 2022 at 11:37:52AM -0500, Kevin O'Connor wrote: > > Thanks. I don't know enough about NVMe to review this patch though. > > Maybe Julian or Alex could comment? > > Happy to hear their comments on this. However, I

[SeaBIOS] Re: [PATCH] nvme: fix LBA format data structure

2022-02-01 Thread Florian Larysch
On Thu, Jan 27, 2022 at 11:37:52AM -0500, Kevin O'Connor wrote: > Thanks. I don't know enough about NVMe to review this patch though. > Maybe Julian or Alex could comment? Happy to hear their comments on this. However, I can also try to explain the reasoning in a bit more detail. This follows

[SeaBIOS] Re: [PATCH] nvme: fix LBA format data structure

2022-01-27 Thread Kevin O'Connor
On Sun, Jan 23, 2022 at 05:43:57PM +0100, Florian Larysch wrote: > The LBA Format Data structure is dword-sized, but struct nvme_lba_format > erroneously contains an additional member, misaligning all LBAF > descriptors after the first and causing them to be misinterpreted. > Remove it. Thanks.