[SeaBIOS] Re: [PATCH] scripts/buildversion.py: allow version to be overridden

2019-06-19 Thread David Woodhouse
On Tue, 2019-06-18 at 18:48 -0400, Kevin O'Connor wrote: > > The main project has an out-of-tree build, and currently *copies* > > everything from the SeaBIOS submodule (except .git) into the build > > directory and building it there. It creates a .version file with the > > overall version number

[SeaBIOS] Re: [PATCH] scripts/buildversion.py: allow version to be overridden

2019-06-18 Thread Kevin O'Connor
On Thu, Jun 13, 2019 at 07:01:06PM +0100, David Woodhouse wrote: > On Thu, 2019-06-13 at 13:33 -0400, Kevin O'Connor wrote: > > Can you give some background on how this is intended to be used? > > > > We used to allow the version string to be overridden, but we found the > > results were a bit

[SeaBIOS] Re: [PATCH] scripts/buildversion.py: allow version to be overridden

2019-06-13 Thread David Woodhouse
On Thu, 2019-06-13 at 13:33 -0400, Kevin O'Connor wrote: > Can you give some background on how this is intended to be used? > > We used to allow the version string to be overridden, but we found the > results were a bit chaotic - different people chose different names > and it was hard to

[SeaBIOS] Re: [PATCH] scripts/buildversion.py: allow version to be overridden

2019-06-13 Thread Kevin O'Connor
On Thu, Jun 13, 2019 at 04:25:53PM +0100, David Woodhouse wrote: > Signed-off-by: David Woodhouse > --- > scripts/buildversion.py | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/scripts/buildversion.py b/scripts/buildversion.py > index 8875497..fc2decd 100755 > ---