[SeaBIOS] Re: [PATCH] smbios: avoid integer overflow adding SMBIOS type 0 table

2020-09-25 Thread Kevin O'Connor
On Mon, Sep 14, 2020 at 10:38:26AM +0100, Daniel P. Berrangé wrote: > On Fri, Sep 11, 2020 at 02:03:23PM -0400, Kevin O'Connor wrote: > > On Tue, Sep 08, 2020 at 04:21:03PM +0100, Daniel P. Berrangé wrote: > > > SeaBIOS implements the SMBIOS 2.1 entry point which is limited to a > > > maximum leng

[SeaBIOS] Re: [PATCH] smbios: avoid integer overflow adding SMBIOS type 0 table

2020-09-14 Thread Daniel P . Berrangé
On Fri, Sep 11, 2020 at 02:03:23PM -0400, Kevin O'Connor wrote: > On Tue, Sep 08, 2020 at 04:21:03PM +0100, Daniel P. Berrangé wrote: > > SeaBIOS implements the SMBIOS 2.1 entry point which is limited to a > > maximum length of 0x. If the SMBIOS data received from QEMU is large > > enough, the

[SeaBIOS] Re: [PATCH] smbios: avoid integer overflow adding SMBIOS type 0 table

2020-09-11 Thread Kevin O'Connor
On Tue, Sep 08, 2020 at 04:21:03PM +0100, Daniel P. Berrangé wrote: > SeaBIOS implements the SMBIOS 2.1 entry point which is limited to a > maximum length of 0x. If the SMBIOS data received from QEMU is large > enough, then adding the type 0 table will cause integer overflow. This > results in

[SeaBIOS] Re: [PATCH] smbios: avoid integer overflow adding SMBIOS type 0 table

2020-09-09 Thread Philippe Mathieu-Daudé
On 9/8/20 5:21 PM, Daniel P. Berrangé wrote: > SeaBIOS implements the SMBIOS 2.1 entry point which is limited to a > maximum length of 0x. If the SMBIOS data received from QEMU is large > enough, then adding the type 0 table will cause integer overflow. This > results in fun behaviour such as a