[SeaBIOS] Re: [PATCH 3/4] csm: Enable boot from pci option rom

2019-12-10 Thread Your Real Name
On Mon, Dec 09, 2019 at 01:09:11PM +0100, Gerd Hoffmann wrote: > On Fri, Dec 06, 2019 at 08:17:04PM -0800, Your Real Name wrote: > > On Thu, Dec 05, 2019 at 07:06:37AM +0100, Gerd Hoffmann wrote: > > > Hi, > > > > > > > The priority value(the last argument we pass to boot_add_bev()) will > > >

[SeaBIOS] Re: [PATCH 3/4] csm: Enable boot from pci option rom

2019-12-09 Thread Gerd Hoffmann
On Fri, Dec 06, 2019 at 08:17:04PM -0800, Your Real Name wrote: > On Thu, Dec 05, 2019 at 07:06:37AM +0100, Gerd Hoffmann wrote: > > Hi, > > > > > The priority value(the last argument we pass to boot_add_bev()) will > > > affect > > > the order of the boot list. The getRomPriority() will

[SeaBIOS] Re: [PATCH 3/4] csm: Enable boot from pci option rom

2019-12-06 Thread Your Real Name
On Thu, Dec 05, 2019 at 07:06:37AM +0100, Gerd Hoffmann wrote: > Hi, > > > The priority value(the last argument we pass to boot_add_bev()) will affect > > the order of the boot list. The getRomPriority() will calculate the final > > priority based on the system provided BBS, etc. This is even

[SeaBIOS] Re: [PATCH 3/4] csm: Enable boot from pci option rom

2019-12-04 Thread Gerd Hoffmann
Hi, > The priority value(the last argument we pass to boot_add_bev()) will affect > the order of the boot list. The getRomPriority() will calculate the final > priority based on the system provided BBS, etc. This is even true in CSM case. > If we drop the getRomPriority call and instead do: >

[SeaBIOS] Re: [PATCH 3/4] csm: Enable boot from pci option rom

2019-12-04 Thread Your Real Name
On Tue, Dec 03, 2019 at 11:07:36AM +0100, Gerd Hoffmann wrote: > > > > +static int rom_instance; > > > > + > > > > > > What is this? Not used anywhere in the patch ... > > > > This is required on calling getRomPriority(). > > Please check below lines in the patch. > >

[SeaBIOS] Re: [PATCH 3/4] csm: Enable boot from pci option rom

2019-12-03 Thread Gerd Hoffmann
> > > +static int rom_instance; > > > + > > > > What is this? Not used anywhere in the patch ... > > This is required on calling getRomPriority(). > Please check below lines in the patch. > boot_add_bev(FLATPTR_TO_SEG(rom), pnp->bev, pnp->productname, >

[SeaBIOS] Re: [PATCH 3/4] csm: Enable boot from pci option rom

2019-12-02 Thread Your Real Name
On Wed, Nov 27, 2019 at 08:09:18AM +0100, Gerd Hoffmann wrote: > On Mon, Nov 25, 2019 at 07:26:17PM -0800, Your Real Name wrote: > > From 9ca6590769692b99e98acf48acc3ce700238e451 Mon Sep 17 00:00:00 2001 > > From: gaobin > > Date: Thu, 19 Sep 2019 22:47:43 -0700 > > Subject: [PATCH 3/4] csm:

[SeaBIOS] Re: [PATCH 3/4] csm: Enable boot from pci option rom

2019-11-26 Thread Gerd Hoffmann
On Mon, Nov 25, 2019 at 07:26:17PM -0800, Your Real Name wrote: > From 9ca6590769692b99e98acf48acc3ce700238e451 Mon Sep 17 00:00:00 2001 > From: gaobin > Date: Thu, 19 Sep 2019 22:47:43 -0700 > Subject: [PATCH 3/4] csm: Enable boot from pci option rom > > In csm mode, the bev pointer of the pci