[SeaBIOS] Re: [PATCH v2] csm: Fix boot priority translation

2019-06-28 Thread Alexander Graf
On 20.06.19 14:07, David Woodhouse wrote: For CSM, the highest priority for a boot entry is zero. SeaBIOS doesn't use zero, and the highest priority is 1. Make the results of csm_bootprio_*() conform to that convention. Also explicitly handle the BBS_DO_NOT_BOOT_FROM and BBS_IGNORE_ENTRY

[SeaBIOS] Re: [PATCH v2] csm: Fix boot priority translation

2019-06-21 Thread Gerd Hoffmann
On Fri, Jun 21, 2019 at 11:33:08AM +0100, David Woodhouse wrote: > On Fri, 2019-06-21 at 10:40 +0200, Gerd Hoffmann wrote: > > Hi, > > > > > Our downstream patch for not initialising NVMe controllers if we aren't > > > going to boot from them, makes its decision based on the priority. > > > >

[SeaBIOS] Re: [PATCH v2] csm: Fix boot priority translation

2019-06-21 Thread David Woodhouse
On Fri, 2019-06-21 at 10:40 +0200, Gerd Hoffmann wrote: > Hi, > > > Our downstream patch for not initialising NVMe controllers if we aren't > > going to boot from them, makes its decision based on the priority. > > What is the state of that patch btw? It's on my "technical debt that I want to

[SeaBIOS] Re: [PATCH v2] csm: Fix boot priority translation

2019-06-21 Thread Gerd Hoffmann
Hi, > Our downstream patch for not initialising NVMe controllers if we aren't > going to boot from them, makes its decision based on the priority. What is the state of that patch btw? I remember it being posted a while back, suggestion was to make it generic (skip init for everything which

[SeaBIOS] Re: [PATCH v2] csm: Fix boot priority translation

2019-06-20 Thread Kevin O'Connor
On Thu, Jun 20, 2019 at 03:12:33PM +0100, David Woodhouse wrote: > On Thu, 2019-06-20 at 09:43 -0400, Kevin O'Connor wrote: > > On Thu, Jun 20, 2019 at 01:07:45PM +0100, David Woodhouse wrote: > > > For CSM, the highest priority for a boot entry is zero. SeaBIOS doesn't > > > use zero, and the

[SeaBIOS] Re: [PATCH v2] csm: Fix boot priority translation

2019-06-20 Thread David Woodhouse
On Thu, 2019-06-20 at 09:43 -0400, Kevin O'Connor wrote: > On Thu, Jun 20, 2019 at 01:07:45PM +0100, David Woodhouse wrote: > > For CSM, the highest priority for a boot entry is zero. SeaBIOS doesn't > > use zero, and the highest priority is 1. > > FYI, SeaBIOS does treat zero as the highest

[SeaBIOS] Re: [PATCH v2] csm: Fix boot priority translation

2019-06-20 Thread Kevin O'Connor
On Thu, Jun 20, 2019 at 01:07:45PM +0100, David Woodhouse wrote: > For CSM, the highest priority for a boot entry is zero. SeaBIOS doesn't > use zero, and the highest priority is 1. FYI, SeaBIOS does treat zero as the highest priority. And a negative priority means "use default priority". I'm