Re: [SeaBIOS] [PATCH 2/2] fw/pci: map memory and IO regions for multiple pci root buses

2014-11-24 Thread Marcel Apfelbaum
On Mon, 2014-11-24 at 13:28 +0100, Gerd Hoffmann wrote: On Mo, 2014-11-24 at 11:47 +0200, Marcel Apfelbaum wrote: Removed the assumption that the system has only one primary root bus. When mapping memory and IO regions go over all buses, skipping secondary and absent buses. Hi Gerd,

Re: [SeaBIOS] [PATCH 2/2] fw/pci: map memory and IO regions for multiple pci root buses

2014-11-24 Thread Gerd Hoffmann
On Mo, 2014-11-24 at 15:38 +0200, Marcel Apfelbaum wrote: On Mon, 2014-11-24 at 13:28 +0100, Gerd Hoffmann wrote: On Mo, 2014-11-24 at 11:47 +0200, Marcel Apfelbaum wrote: Removed the assumption that the system has only one primary root bus. When mapping memory and IO regions go over all

Re: [SeaBIOS] [PATCH 2/2] fw/pci: map memory and IO regions for multiple pci root buses

2014-11-24 Thread Marcel Apfelbaum
On Mon, 2014-11-24 at 15:28 +0100, Gerd Hoffmann wrote: On Mo, 2014-11-24 at 15:38 +0200, Marcel Apfelbaum wrote: On Mon, 2014-11-24 at 13:28 +0100, Gerd Hoffmann wrote: On Mo, 2014-11-24 at 11:47 +0200, Marcel Apfelbaum wrote: Removed the assumption that the system has only one primary

Re: [SeaBIOS] [PATCH 2/2] fw/pci: map memory and IO regions for multiple pci root buses

2014-11-24 Thread Kevin O'Connor
On Mon, Nov 24, 2014 at 03:28:52PM +0100, Gerd Hoffmann wrote: On Mo, 2014-11-24 at 15:38 +0200, Marcel Apfelbaum wrote: On Mon, 2014-11-24 at 13:28 +0100, Gerd Hoffmann wrote: Hmm, that assigns the io regions in bus order. I think it would be better to integrate this with the packing

Re: [SeaBIOS] [PATCH 2/2] fw/pci: map memory and IO regions for multiple pci root buses

2014-11-24 Thread Kevin O'Connor
On Mon, Nov 24, 2014 at 12:21:31PM -0500, Kevin O'Connor wrote: On Mon, Nov 24, 2014 at 03:28:52PM +0100, Gerd Hoffmann wrote: I think I would try to reuse the existing code which does the same for bridges. Reuse struct pci_bus to add one more level (and maybe rename the struct), then have

Re: [SeaBIOS] [PATCH 2/2] fw/pci: map memory and IO regions for multiple pci root buses

2014-11-24 Thread Marcel Apfelbaum
On Mon, 2014-11-24 at 13:01 -0500, Kevin O'Connor wrote: On Mon, Nov 24, 2014 at 12:21:31PM -0500, Kevin O'Connor wrote: On Mon, Nov 24, 2014 at 03:28:52PM +0100, Gerd Hoffmann wrote: I think I would try to reuse the existing code which does the same for bridges. Reuse struct pci_bus to

Re: [SeaBIOS] [PATCH 2/2] fw/pci: map memory and IO regions for multiple pci root buses

2014-11-24 Thread Kevin O'Connor
On Mon, Nov 24, 2014 at 09:38:38PM +0200, Marcel Apfelbaum wrote: On Mon, 2014-11-24 at 13:01 -0500, Kevin O'Connor wrote: On Mon, Nov 24, 2014 at 12:21:31PM -0500, Kevin O'Connor wrote: On Mon, Nov 24, 2014 at 03:28:52PM +0100, Gerd Hoffmann wrote: I think I would try to reuse the

Re: [SeaBIOS] [PATCH 2/2] fw/pci: map memory and IO regions for multiple pci root buses

2014-11-24 Thread Marcel Apfelbaum
On Mon, 2014-11-24 at 15:18 -0500, Kevin O'Connor wrote: On Mon, Nov 24, 2014 at 09:38:38PM +0200, Marcel Apfelbaum wrote: On Mon, 2014-11-24 at 13:01 -0500, Kevin O'Connor wrote: On Mon, Nov 24, 2014 at 12:21:31PM -0500, Kevin O'Connor wrote: On Mon, Nov 24, 2014 at 03:28:52PM +0100,