Re: [SeaBIOS] [Qemu-devel] [RFC PATCH v4 07/30] Add SIZE type to qdev properties

2013-03-20 Thread li guang
在 2012-12-18二的 13:41 +0100,Vasilis Liaskovitis写道: This patch adds a 'SIZE' type property to qdev. It will make dimm description more convenient by allowing sizes to be specified with K,M,G,T prefixes instead of number of bytes e.g.: -device dimm,id=mem0,size=2G,bus=membus.0 Credits go

Re: [SeaBIOS] [Qemu-devel] [RFC PATCH v4 00/30] ACPI memory hotplug

2013-03-20 Thread li guang
在 2013-01-09三的 01:08 +0100,Andreas Färber写道: Am 18.12.2012 13:41, schrieb Vasilis Liaskovitis: Because dimm layout needs to be configured on machine-boot, all dimm devices need to be specified on startup command line (either with populated=on or with populated=off). The dimm information

Re: [SeaBIOS] [Qemu-devel] [RESEND PATCH v2] pciinit: Enable default VGA device

2013-03-20 Thread Gerd Hoffmann
Hi, Turns out it's this: commit 76e58028d28e78431f9de3cee0b3c88d807fa39d Author: Kevin O'Connor ke...@koconnor.net Date: Wed Mar 6 21:50:09 2013 -0500 acpi: Eliminate BDAT parameter passing to DSDT code. The BDAT construct is the only ACPI mechanism that relies on

Re: [SeaBIOS] [PATCH] src/Kconfig: Add note that boot interface is needed

2013-03-20 Thread Paul Menzel
Am Dienstag, den 19.03.2013, 22:18 -0400 schrieb Kevin O'Connor: On Wed, Mar 20, 2013 at 12:59:53AM +0100, Paul Menzel wrote: Am Dienstag, den 19.03.2013, 19:05 -0400 schrieb Kevin O'Connor: Basically everything under the BIOS interfaces menu is low-level and should not be changed without

Re: [SeaBIOS] [PATCH] src/Kconfig: Add note that boot interface is needed

2013-03-20 Thread Peter Stuge
Paul Menzel wrote: it would be nice if it is clear for noobs like me, what certain option do and what effects they have. The good way to fix that is for you to send patches for the Kconfig help messages. *After* you have researched what the options do. //Peter pgptDFHdnLwQL.pgp Description:

Re: [SeaBIOS] [Qemu-devel] [RFC PATCH v4 07/30] Add SIZE type to qdev properties

2013-03-20 Thread Eric Blake
On 03/20/2013 12:06 AM, li guang wrote: +return snprintf(dest, len, %0.03f%c, (double)*ptr/div, suffixes[i]); ^^ ^^^ +} + IMHO, you may need (double)(*ptr/div), for type cast is right associated. No, the code as written is

[SeaBIOS] [PATCH please reply] make acpi bits GPLv2 compatible

2013-03-20 Thread Michael S. Tsirkin
You are getting this mail because you might have contributed code to one of the files in seabios that we want to reuse in QEMU, when this file was under GPLv3 or LGPLv3. QEMU is GPLv2 at the moment, so as a step in the process of moving acpi tables to qemu, we need to make sure the code we'll be

Re: [SeaBIOS] [Qemu-devel] [RESEND PATCH v2] pciinit: Enable default VGA device

2013-03-20 Thread Alex Williamson
On Wed, 2013-03-20 at 08:17 +0100, Gerd Hoffmann wrote: Hi, Turns out it's this: commit 76e58028d28e78431f9de3cee0b3c88d807fa39d Author: Kevin O'Connor ke...@koconnor.net Date: Wed Mar 6 21:50:09 2013 -0500 acpi: Eliminate BDAT parameter passing to DSDT code.

Re: [SeaBIOS] [PATCH please reply] make acpi bits GPLv2 compatible

2013-03-20 Thread Jan Kiszka
On 2013-03-20 16:57, Michael S. Tsirkin wrote: You are getting this mail because you might have contributed code to one of the files in seabios that we want to reuse in QEMU, when this file was under GPLv3 or LGPLv3. QEMU is GPLv2 at the moment, so as a step in the process of moving acpi

Re: [SeaBIOS] [PATCH please reply] make acpi bits GPLv2 compatible

2013-03-20 Thread Gleb Natapov
On Wed, Mar 20, 2013 at 05:57:53PM +0200, Michael S. Tsirkin wrote: You are getting this mail because you might have contributed code to one of the files in seabios that we want to reuse in QEMU, when this file was under GPLv3 or LGPLv3. QEMU is GPLv2 at the moment, so as a step in the

Re: [SeaBIOS] [Qemu-devel] [RESEND PATCH v2] pciinit: Enable default VGA device

2013-03-20 Thread Gerd Hoffmann
Hi, With qemu/master you can just use 'qemu -L /path/to/seabios/out' instead and qemu will pick up both bios.bin and dsdt from the fresh seabios build directory then (and anything else it doesn't find there from the default locations). Thanks, yes that's it. QEMU only seems to look in

Re: [SeaBIOS] [Qemu-devel] [RESEND PATCH v2] pciinit: Enable default VGA device

2013-03-20 Thread Alex Williamson
On Wed, 2013-03-20 at 17:46 +0100, Gerd Hoffmann wrote: Hi, With qemu/master you can just use 'qemu -L /path/to/seabios/out' instead and qemu will pick up both bios.bin and dsdt from the fresh seabios build directory then (and anything else it doesn't find there from the default

[SeaBIOS] [PATCH v3] pciinit: Enable default VGA device

2013-03-20 Thread Alex Williamson
As QEMU gains PCI bridge and PCIe root port support, we won't always find the VGA device on the root bus. We therefore need to add support to find and enable a VGA device and the path to it through the VGA Enable support in the PCI bridge control register. Signed-off-by: Alex Williamson

Re: [SeaBIOS] [PATCH v3] pciinit: Enable default VGA device

2013-03-20 Thread Paul Menzel
Dear Alex, Am Mittwoch, den 20.03.2013, 10:58 -0600 schrieb Alex Williamson: As QEMU gains PCI bridge and PCIe root port support, could you give a commit or version for QEMU please. we won't always find the VGA device on the root bus. We therefore need to add support to find and enable a

Re: [SeaBIOS] [PATCH v3] pciinit: Enable default VGA device

2013-03-20 Thread Alex Williamson
On Wed, 2013-03-20 at 19:05 +0100, Paul Menzel wrote: Dear Alex, Am Mittwoch, den 20.03.2013, 10:58 -0600 schrieb Alex Williamson: As QEMU gains PCI bridge and PCIe root port support, could you give a commit or version for QEMU please. This would be targeted towards QEMU 1.5. Michael

Re: [SeaBIOS] [PATCH please reply] make acpi bits GPLv2 compatible

2013-03-20 Thread Marcelo Tosatti
On Wed, Mar 20, 2013 at 05:57:53PM +0200, Michael S. Tsirkin wrote: You are getting this mail because you might have contributed code to one of the files in seabios that we want to reuse in QEMU, when this file was under GPLv3 or LGPLv3. QEMU is GPLv2 at the moment, so as a step in the

[SeaBIOS] [PATCH 2/2] accept MADT over fw_cfg

2013-03-20 Thread Laszlo Ersek
Signed-off-by: Laszlo Ersek ler...@redhat.com --- src/acpi.c | 19 --- 1 files changed, 16 insertions(+), 3 deletions(-) diff --git a/src/acpi.c b/src/acpi.c index 8bbc92b..611553e 100644 --- a/src/acpi.c +++ b/src/acpi.c @@ -797,13 +797,13 @@ acpi_setup(void) struct

[SeaBIOS] [PATCH 1/2] build_madt(): fix intsrcovr-{gsi, flags} and local_nmi-flags byte order

2013-03-20 Thread Laszlo Ersek
These fields are wider than a single byte; stick to cpu_to_leXX() for consistency with other field settings in this function. Signed-off-by: Laszlo Ersek ler...@redhat.com --- src/acpi.c | 12 +++- 1 files changed, 7 insertions(+), 5 deletions(-) diff --git a/src/acpi.c b/src/acpi.c

[SeaBIOS] [PATCH 0/2] accept MADT over fw_cfg

2013-03-20 Thread Laszlo Ersek
The first patch cleans up some field assignments in build_madt(). The second one handles the case when MADT is provided by qemu over fw_cfg. I'll soon post the qemu-side series as well. I cross-tested {patched, unpatched} qemu with {patched, unpatched} seabios. Inside a RHEL-6 guest I dumped the

Re: [SeaBIOS] [PATCH please reply] make acpi bits GPLv2 compatible

2013-03-20 Thread Paolo Bonzini
Il 20/03/2013 16:57, Michael S. Tsirkin ha scritto: You are getting this mail because you might have contributed code to one of the files in seabios that we want to reuse in QEMU, when this file was under GPLv3 or LGPLv3. QEMU is GPLv2 at the moment, so as a step in the process of moving

Re: [SeaBIOS] [PATCH please reply] make acpi bits GPLv2 compatible

2013-03-20 Thread Jason Baron
On 03/20/2013 11:57 AM, Michael S. Tsirkin wrote: You are getting this mail because you might have contributed code to one of the files in seabios that we want to reuse in QEMU, when this file was under GPLv3 or LGPLv3. QEMU is GPLv2 at the moment, so as a step in the process of moving acpi

Re: [SeaBIOS] [PATCH please reply] make acpi bits GPLv2 compatible

2013-03-20 Thread Kevin O'Connor
On Wed, Mar 20, 2013 at 05:57:53PM +0200, Michael S. Tsirkin wrote: You are getting this mail because you might have contributed code to one of the files in seabios that we want to reuse in QEMU, when this file was under GPLv3 or LGPLv3. QEMU is GPLv2 at the moment, so as a step in the

Re: [SeaBIOS] [PATCH 1/2] build_madt(): fix intsrcovr-{gsi, flags} and local_nmi-flags byte order

2013-03-20 Thread Kevin O'Connor
On Wed, Mar 20, 2013 at 10:53:04PM +0100, Laszlo Ersek wrote: These fields are wider than a single byte; stick to cpu_to_leXX() for consistency with other field settings in this function. Thanks. We can do this to improve documentation. Please ack that you are okay with licensing under

Re: [SeaBIOS] [PATCH please reply] make acpi bits GPLv2 compatible

2013-03-20 Thread Laszlo Ersek
On 03/20/13 16:57, Michael S. Tsirkin wrote: You are getting this mail because you might have contributed code to one of the files in seabios that we want to reuse in QEMU, when this file was under GPLv3 or LGPLv3. QEMU is GPLv2 at the moment, so as a step in the process of moving acpi

Re: [SeaBIOS] [PATCH 1/2] build_madt(): fix intsrcovr-{gsi, flags} and local_nmi-flags byte order

2013-03-20 Thread Laszlo Ersek
On 03/21/13 00:52, Kevin O'Connor wrote: On Wed, Mar 20, 2013 at 10:53:04PM +0100, Laszlo Ersek wrote: These fields are wider than a single byte; stick to cpu_to_leXX() for consistency with other field settings in this function. Thanks. We can do this to improve documentation. Please ack

Re: [SeaBIOS] [PATCH please reply] make acpi bits GPLv2 compatible

2013-03-20 Thread Laszlo Ersek
On 03/20/13 16:57, Michael S. Tsirkin wrote: You are getting this mail because you might have contributed code to one of the files in seabios that we want to reuse in QEMU, when this file was under GPLv3 or LGPLv3. QEMU is GPLv2 at the moment, so as a step in the process of moving acpi

Re: [SeaBIOS] [PATCH please reply] make acpi bits GPLv2 compatible

2013-03-20 Thread Kaneshige, Kenji
Acked-by: Kenji Kaneshige kaneshige.ke...@jp.fujitsu.com Regards, Kenji Kaneshige -Original Message- From: Michael S. Tsirkin [mailto:m...@redhat.com] Sent: Thursday, March 21, 2013 12:58 AM To: seabios@seabios.org Cc: David Woodhouse; Eduardo Habkost; Gerd Hoffmann; Gleb Natapov;

Re: [SeaBIOS] [PATCH please reply] make acpi bits GPLv2 compatible

2013-03-20 Thread Isaku Yamahata
Acked-by: Isaku Yamahata yamah...@valinux.co.jp thanks, On Wed, Mar 20, 2013 at 05:57:53PM +0200, Michael S. Tsirkin wrote: You are getting this mail because you might have contributed code to one of the files in seabios that we want to reuse in QEMU, when this file was under GPLv3 or LGPLv3.