Re: [SeaBIOS] [PATCH 2/2] vgabios: Limit the range of the VBE number of pages parameter.

Am Freitag, den 13.09.2013, 16:24 -0400 schrieb Kevin O'Connor: Looking at the output of other VGA BIOS implementations, it appears that the number of available video pages reported is always between 1 and 127. That is including 1 and 127, right? Signed-off-by: Kevin O'Connor

Re: [SeaBIOS] [PATCH 2/2] vgabios: Limit the range of the VBE number of pages parameter.

Paul Menzel wrote: +if (pages 2) +pages++; Can pages be 0? If yes, it would be 0 again after substracting 1. Should it be `pages = 1` instead of `pages++`? pages=2; //Peter ___ SeaBIOS mailing list SeaBIOS@seabios.org

Re: [SeaBIOS] [PATCH 2/2] vgabios: Limit the range of the VBE number of pages parameter.

On Sat, Sep 14, 2013 at 09:11:02AM +0200, Paul Menzel wrote: Am Freitag, den 13.09.2013, 16:24 -0400 schrieb Kevin O'Connor: Looking at the output of other VGA BIOS implementations, it appears that the number of available video pages reported is always between 1 and 127. That is

[SeaBIOS] [PATCH 02/23] Move keyboard calling code from util.c to boot.c.

Signed-off-by: Kevin O'Connor ke...@koconnor.net --- src/boot.c | 44 +++- src/util.c | 41 - src/util.h | 1 - 3 files changed, 43 insertions(+), 43 deletions(-) diff --git a/src/boot.c b/src/boot.c index

[SeaBIOS] [PATCH 01/23] Split x86 specific functions out of util.c/h to new files x86.c/h.

Signed-off-by: Kevin O'Connor ke...@koconnor.net --- Makefile | 2 +- src/bregs.h | 22 +-- src/fw/acpi.c | 1 + src/fw/mptable.c | 1 + src/fw/mtrr.c | 1 + src/fw/paravirt.c | 1 + src/fw/shadow.c | 1 + src/fw/smbios.c | 1 + src/fw/smm.c |

[SeaBIOS] [PATCH 00/23] Include file cleanups

This patch series attempts to cleanup some of the include files within SeaBIOS. There are three main goals: split out the complex users of util.h into their own header files, introduce a new directory std/ for header files that just define standard bios interfaces, and make sure no header files

[SeaBIOS] [PATCH 05/23] Move stacks.c definitions from util.h to new file stacks.h.

Signed-off-by: Kevin O'Connor ke...@koconnor.net --- src/stacks.h | 34 ++ 1 file changed, 34 insertions(+) create mode 100644 src/stacks.h diff --git a/src/stacks.h b/src/stacks.h new file mode 100644 index 000..5ee4adc --- /dev/null +++ b/src/stacks.h @@

[SeaBIOS] [PATCH 04/23] Move stacks.c definitions from util.h to new file stacks.h.

Signed-off-by: Kevin O'Connor ke...@koconnor.net --- src/apm.c | 1 + src/block.c | 1 + src/bootsplash.c | 1 + src/clock.c | 1 + src/disk.c| 1 + src/fw/coreboot.c | 1 + src/fw/csm.c | 1 + src/fw/smp.c | 1 + src/hw/ahci.c | 1 +

[SeaBIOS] [PATCH 06/23] Move romfile definitions from util.h to new file romfile.h.

Signed-off-by: Kevin O'Connor ke...@koconnor.net --- src/boot.c| 1 + src/bootsplash.c | 1 + src/fw/acpi.c | 1 + src/fw/coreboot.c | 1 + src/fw/mptable.c | 1 + src/fw/paravirt.c | 1 + src/fw/smbios.c | 1 + src/fw/smp.c | 1 + src/hw/floppy.c | 1 +

[SeaBIOS] [PATCH 09/23] Move definition of struct segoff_s from farptr.h to types.h.

The segoff_s definition is used by a number of header files that would not otherwise need farptr.h, so move it to a more central location. Signed-off-by: Kevin O'Connor ke...@koconnor.net --- src/bregs.h | 1 - src/disk.h | 2 -- src/farptr.h | 10 -- src/hw/pic.h | 1 - src/pmm.c

[SeaBIOS] [PATCH 11/23] Move pirtable definitions from hw/pci.h to std/pirtable.h and util.h.

Signed-off-by: Kevin O'Connor ke...@koconnor.net --- src/fw/biostables.c | 2 +- src/fw/pirtable.c | 2 +- src/hw/pci.h| 40 src/pcibios.c | 1 + src/std/pirtable.h | 35 +++ src/util.h | 4

[SeaBIOS] [PATCH 13/23] Move vbe.h to std/vbe.h.

Signed-off-by: Kevin O'Connor ke...@koconnor.net --- src/bootsplash.c| 2 +- src/{ = std}/vbe.h | 0 vgasrc/bochsvga.c | 2 +- vgasrc/vbe.c| 2 +- vgasrc/vgabios.c| 2 +- 5 files changed, 4 insertions(+), 4 deletions(-) rename src/{ = std}/vbe.h (100%) diff --git

[SeaBIOS] [PATCH 12/23] Move optionroms.h to std/optionrom.h and util.h.

Signed-off-by: Kevin O'Connor ke...@koconnor.net --- src/fw/csm.c | 2 +- src/malloc.c | 2 +- src/optionroms.c | 2 +- src/{optionroms.h = std/optionrom.h} | 3 --- src/util.h| 4

[SeaBIOS] [PATCH 10/23] build: Fix import of gcc dependency files.

Make sure dependency file import works with new hw/ and fw/ sub-directories. Signed-off-by: Kevin O'Connor ke...@koconnor.net --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile b/Makefile index fb1f81f..b846491 100644 --- a/Makefile +++ b/Makefile @@ -253,4

[SeaBIOS] [PATCH 18/23] Move pnpbios definition to new file std/pnpbios.h.

Signed-off-by: Kevin O'Connor ke...@koconnor.net --- src/optionroms.c | 1 + src/pnpbios.c | 19 +-- src/std/pnpbios.h | 24 src/util.h| 1 - 4 files changed, 26 insertions(+), 19 deletions(-) create mode 100644 src/std/pnpbios.h diff

[SeaBIOS] [PATCH 21/23] Move standard bda type info from biosvar.h to std/bda.h.

Signed-off-by: Kevin O'Connor ke...@koconnor.net --- src/biosvar.h | 161 ++--- src/fw/csm.c | 3 +- src/post.c | 2 +- src/resume.c | 4 +- src/std/bda.h | 159

[SeaBIOS] [PATCH 20/23] Split disk.h into block.h and std/disk.h.

Signed-off-by: Kevin O'Connor ke...@koconnor.net --- src/block.c | 35 ++- src/block.h | 129 +++ src/boot.c | 3 +- src/cdrom.c | 19 +--- src/clock.c | 1 - src/disk.c | 28 + src/disk.h | 290

[SeaBIOS] [PATCH 19/23] Move pmm definitions to new file std/pmm.h.

Signed-off-by: Kevin O'Connor ke...@koconnor.net --- src/pmm.c | 14 +- src/std/pmm.h | 19 +++ 2 files changed, 20 insertions(+), 13 deletions(-) create mode 100644 src/std/pmm.h diff --git a/src/pmm.c b/src/pmm.c index cce0f29..be03bdb 100644 --- a/src/pmm.c

[SeaBIOS] [PATCH 22/23] Merge bmp.h, boot.h, jpeg.h, and post.h into util.h.

Signed-off-by: Kevin O'Connor ke...@koconnor.net --- src/bmp.c| 15 +-- src/bmp.h| 25 - src/boot.c | 1 - src/boot.h | 28 src/bootsplash.c | 2 -- src/fw/coreboot.c| 1 -