Re: [SeaBIOS] Stable seabios release

On 02/24/2017 09:09 AM, Gerd Hoffmann wrote: > Hi, > >> You may want to consider the following additional patches for the next >> stable release: >> >> 106543de - ahci: Set upper 32-bit registers to zero Awesome, thanks Gerd! --js >> 970af16e - vgasrc: Increase debug level >> dbf9dd27 -

[SeaBIOS] [PATCH 0/9] add support for generic lun enumeration

A number of SCSI drivers currently only see luns #0 in their targets. This may be a problem when drives have to be assigned bigger lun numbers, e.g. because the storage controllers don't provide enough target numbers to accomodate all drives. (In particular, I'm about to submit a driver for

[SeaBIOS] [PATCH 6/9] pvscsi: fix the comment about lun enumeration

The comment in pvscsi_scan_target (presumably c from another driver) reads that REPORTS LUNS should better be used to enumerate the luns on the target. However, according to the Linux driver, the device supports no more than a single lun per target. So adjust the comment to tell exactly that.

[SeaBIOS] [PATCH 3/9] virtio-scsi: enumerate luns with REPORT LUNS

Signed-off-by: Roman Kagan --- src/hw/virtio-scsi.c | 38 ++ 1 file changed, 26 insertions(+), 12 deletions(-) diff --git a/src/hw/virtio-scsi.c b/src/hw/virtio-scsi.c index 5fb9409..7490ec0 100644 --- a/src/hw/virtio-scsi.c +++

[SeaBIOS] [PATCH 5/9] usb-uas: enumerate luns with REPORT LUNS

Signed-off-by: Roman Kagan --- src/hw/usb-uas.c | 45 + 1 file changed, 29 insertions(+), 16 deletions(-) diff --git a/src/hw/usb-uas.c b/src/hw/usb-uas.c index 10e3845..f00221a 100644 --- a/src/hw/usb-uas.c +++

[SeaBIOS] [PATCH 1/9] blockcmd: accept only disks and CD-ROMs

Luns that report to INQUIRY with a type other than CD-ROM are considered disks. This isn't necessarily the case; working with such luns as disks may lead to unpredictable results. So bail out if the lun is neither CD-ROM nor disk. Signed-off-by: Roman Kagan ---

[SeaBIOS] [PATCH 4/9] esp-scsi: enumerate luns with REPORT LUNS

Signed-off-by: Roman Kagan --- src/hw/esp-scsi.c | 35 +-- 1 file changed, 25 insertions(+), 10 deletions(-) diff --git a/src/hw/esp-scsi.c b/src/hw/esp-scsi.c index d2ba023..57d3832 100644 --- a/src/hw/esp-scsi.c +++ b/src/hw/esp-scsi.c @@

[SeaBIOS] [PATCH 9/9] lsi-scsi: try to enumerate luns with REPORT LUNS

Enumerate active luns with REPORT LUNS and, if that fails[*], fall back to sequentially enumerating them up to (arbitrarily chosen) #8 [**]. [*] in current QEMU, REPORT LUNS does fail in lsi53c895a because the returned data is smaller than the allocation length which is (wrongly) considered an

[SeaBIOS] [PATCH 8/9] lsi-scsi: reset in case of a serious problem

When the device reports a serious problem via SIST[01] registers, it needs to be reset, otherwise the following requests will most likely fail, too. In particular, REPORT LUNS which fails (wrongly) with underflow in QEMU makes all the following requests fail, too, rendering the device unusable.

[SeaBIOS] [PATCH 2/9] blockcmd: generic SCSI luns enumeration

Add two generic functions to discover active LUNs on a SCSI target. The functions take a temporary drive descriptor on the target, and a callback to create a new drive descriptor with a new LUN using the temporary one as a template. One of the functions performs REPORT LUNS on the temporary

Re: [SeaBIOS] [PATCH 3/5] nvme: fix reversed loop condition in cmd_readwrite

On 02/24/2017 03:27 AM, Daniel Verkamp wrote: It looks like the intent was to exit the loop if a command failed, but the current code would actually continue looping in that case. Signed-off-by: Daniel Verkamp Reviewed-by: Philippe Mathieu-Daudé ---

Re: [SeaBIOS] [PATCH 5/5] nvme: fix copy-paste mistake in comment

On 02/24/2017 03:27 AM, Daniel Verkamp wrote: Signed-off-by: Daniel Verkamp Reviewed-by: Philippe Mathieu-Daudé --- src/hw/nvme.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/hw/nvme.c b/src/hw/nvme.c index 9fda011..60557ae 100644

Re: [SeaBIOS] [PATCH 4/5] nvme: fix extraction of status code bits

On 02/24/2017 03:27 AM, Daniel Verkamp wrote: The status code field is 8 bits wide starting at bit 1; the previous code would truncate the top bit. Signed-off-by: Daniel Verkamp Reviewed-by: Philippe Mathieu-Daudé --- src/hw/nvme.c | 2 +- 1 file changed,