[SeaBIOS] Re: [PATCH v2] optionrom: disallow int19 redirect for pnp roms.

2019-05-20 Thread Gerd Hoffmann
On Mon, May 20, 2019 at 05:40:16PM -0500, Matt DeVillier wrote: > On Mon, May 20, 2019 at 4:49 PM Kevin O'Connor wrote: > > > On Mon, May 20, 2019 at 04:43:08PM -0500, Matt DeVillier wrote: > > > v2 of the patch works as intended, once 'current.offset != > > current.offset' > > > is corrected to

[SeaBIOS] [PATCH v3] optionrom: disallow int19 redirect for pnp roms.

2019-05-20 Thread Gerd Hoffmann
Check whenever pnp roms attempt to redirect int19, and in case it does log a message and undo the redirect. A pnp rom should not need this, we have BEVs and BCVs for that. Nevertheless there are roms in the wild which are redirecting int19. At least some BIOS implementations for physical hardware

[SeaBIOS] Re: [PATCH v2] optionrom: disallow int19 redirect for pnp roms.

2019-05-20 Thread Matt DeVillier
v2 of the patch works as intended, once 'current.offset != current.offset' is corrected to 'current.offset != seabios.offset' cheers, Matt On Tue, Dec 11, 2018 at 2:03 AM Gerd Hoffmann wrote: > On Mon, Dec 10, 2018 at 09:53:01PM -0500, Kevin O'Connor wrote: > > On Thu, Dec 06, 2018 at

[SeaBIOS] Re: [PATCH v2] optionrom: disallow int19 redirect for pnp roms.

2019-05-20 Thread Kevin O'Connor
On Mon, May 20, 2019 at 04:43:08PM -0500, Matt DeVillier wrote: > v2 of the patch works as intended, once 'current.offset != current.offset' > is corrected to 'current.offset != seabios.offset' FWIW, that code could simply be: static int boot_irq_captured(void) { return GET_IVT(0x19).segoff

[SeaBIOS] Re: [PATCH v2] optionrom: disallow int19 redirect for pnp roms.

2019-05-20 Thread Matt DeVillier
On Mon, May 20, 2019 at 4:49 PM Kevin O'Connor wrote: > On Mon, May 20, 2019 at 04:43:08PM -0500, Matt DeVillier wrote: > > v2 of the patch works as intended, once 'current.offset != > current.offset' > > is corrected to 'current.offset != seabios.offset' > > FWIW, that code could simply be: > >