On Thu, 20 Jan 2022 09:46:09 -0500
Godmar Back wrote:
> [this is a follow-up email; I took qemu-discuss and qemu-devel off the
> distribution list]
>
> On Thu, Jan 20, 2022 at 4:04 AM Igor Mammedov wrote:
> >
> > Legacy MP table is not actively maintained part of the code,
> > hence it's
On 19.01.22 19:45, Kevin O'Connor wrote:
Commit 01f2736cc905d ("nvme: Pass large I/O requests as PRP lists")
introduced multi-page requests using the NVMe PRP mechanism. To store the
list and "first page to write to" hints, it added fields to the NVMe
namespace struct.
Unfortunately, that
On 19.01.22 19:45, Kevin O'Connor wrote:
Rename nvme_io_readwrite() to nvme_io_xfer() and change it so it
implements the debugging dprintf() and it returns -1 on an error.
Signed-off-by: Kevin O'Connor
Reviewed-by: Alexander Graf
Alex
---
src/hw/nvme.c | 34
On 19.01.22 19:45, Kevin O'Connor wrote:
Move bounce buffer processing to a new helper function.
Signed-off-by: Kevin O'Connor
Reviewed-by: Alexander Graf
Alex
---
src/hw/nvme.c | 35 +--
1 file changed, 21 insertions(+), 14 deletions(-)
diff --git
On 19.01.22 19:45, Kevin O'Connor wrote:
When using a prp2 parameter, build it in nvme_prpl_xfer() and pass it
directly to nvme_io_xfer().
Signed-off-by: Kevin O'Connor
Reviewed-by: Alexander Graf
Alex
---
src/hw/nvme.c | 39 ++-
1 file
On 19.01.22 19:45, Kevin O'Connor wrote:
Rename nvme_build_prpl() to nvme_prpl_xfer() and directly invoke
nvme_io_xfer() or nvme_bounce_xfer() from that function.
Signed-off-by: Kevin O'Connor
---
src/hw/nvme-int.h | 1 -
src/hw/nvme.c | 42 --
On 19.01.22 19:45, Kevin O'Connor wrote:
Rename nvme_io_readwrite() to nvme_io_xfer() and change it so it
implements the debugging dprintf() and it returns -1 on an error.
Signed-off-by: Kevin O'Connor
---
src/hw/nvme.c | 34 +-
1 file changed, 17
On 19.01.22 20:11, Kevin O'Connor wrote:
There is no need to create multiple dma bounce buffers as the BIOS
disk code isn't reentrant capable.
Signed-off-by: Kevin O'Connor
Reviewed-by: Alexander Graf
Alex
---
This is a minor cleanup on top of the previous nvme code series.
-Kevin
On 21.01.22 17:48, Kevin O'Connor wrote:
This is a resend of the previous series. Changes since last time:
* Patch 1: Fix function comment on nvme_io_xfer()
* Patch 3-5: Added "goto bounce" to nvme_io_xfer() as suggested by Alex
* Patch 6: Added separate "single dma bounce buffer" patch to
On 21.01.22 17:48, Kevin O'Connor wrote:
Rename nvme_build_prpl() to nvme_prpl_xfer() and directly invoke
nvme_io_xfer() or nvme_bounce_xfer() from that function.
Signed-off-by: Kevin O'Connor
Reviewed-by: Alexander Graf
Alex
---
src/hw/nvme-int.h | 1 -
src/hw/nvme.c | 46
On 21.01.22 17:48, Kevin O'Connor wrote:
Commit 01f2736cc905d ("nvme: Pass large I/O requests as PRP lists")
introduced multi-page requests using the NVMe PRP mechanism. To store the
list and "first page to write to" hints, it added fields to the NVMe
namespace struct.
Unfortunately, that
On 21.01.22 17:54, Kevin O'Connor wrote:
On Fri, Jan 21, 2022 at 05:41:17PM +0100, Alexander Graf wrote:
On 21.01.22 17:02, Kevin O'Connor wrote:
On Fri, Jan 21, 2022 at 03:28:33PM +0100, Alexander Graf wrote:
On 19.01.22 19:45, Kevin O'Connor wrote:
if ((ns->block_size * count) >
When using a prp2 parameter, build it in nvme_prpl_xfer() and pass it
directly to nvme_io_xfer().
Signed-off-by: Kevin O'Connor
Reviewed-by: Alexander Graf
---
src/hw/nvme.c | 39 ++-
1 file changed, 18 insertions(+), 21 deletions(-)
diff --git
Rename nvme_build_prpl() to nvme_prpl_xfer() and directly invoke
nvme_io_xfer() or nvme_bounce_xfer() from that function.
Signed-off-by: Kevin O'Connor
---
src/hw/nvme-int.h | 1 -
src/hw/nvme.c | 46 --
2 files changed, 20 insertions(+), 27
Commit 01f2736cc905d ("nvme: Pass large I/O requests as PRP lists")
introduced multi-page requests using the NVMe PRP mechanism. To store the
list and "first page to write to" hints, it added fields to the NVMe
namespace struct.
Unfortunately, that struct resides in fseg which is read-only at
Move bounce buffer processing to a new helper function.
Signed-off-by: Kevin O'Connor
Reviewed-by: Alexander Graf
---
src/hw/nvme.c | 35 +--
1 file changed, 21 insertions(+), 14 deletions(-)
diff --git a/src/hw/nvme.c b/src/hw/nvme.c
index 608651a..d656e9b
Rename nvme_io_readwrite() to nvme_io_xfer() and change it so it
implements the debugging dprintf() and it returns -1 on an error.
Signed-off-by: Kevin O'Connor
Reviewed-by: Alexander Graf
---
src/hw/nvme.c | 37 ++---
1 file changed, 18 insertions(+), 19
On Fri, Jan 21, 2022 at 05:41:17PM +0100, Alexander Graf wrote:
> On 21.01.22 17:02, Kevin O'Connor wrote:
> > On Fri, Jan 21, 2022 at 03:28:33PM +0100, Alexander Graf wrote:
> > > On 19.01.22 19:45, Kevin O'Connor wrote:
> > > >if ((ns->block_size * count) > (NVME_PAGE_SIZE * 2)) {
> > >
On Wed, 19 Jan 2022 15:48:20 +
Peter Maydell wrote:
> On Wed, 19 Jan 2022 at 14:44, Godmar Back wrote:
> > after upgrading to 6.2.0, I observed that code such as MIT's xv6 (see
> > [1]) is no longer able to detect multiple CPUs. Their code works in
> > 6.1.1, however.
>
> Hi; this isn't
The variable rx_bytes is marked VARLOW, but there was a missing
GET_LOW() to access rx_bytes. Fix by copying rx_bytes to a local
variable and avoid the repetitive segment memory accesses.
Reported-by: Gabe Black
Signed-off-by: Volker Rümelin
Signed-off-by: Kevin O'Connor
---
src/sercon.c |
On Fri, Jan 21, 2022 at 03:28:33PM +0100, Alexander Graf wrote:
>
> On 19.01.22 19:45, Kevin O'Connor wrote:
> > Commit 01f2736cc905d ("nvme: Pass large I/O requests as PRP lists")
> > introduced multi-page requests using the NVMe PRP mechanism. To store the
> > list and "first page to write to"
On 21.01.22 17:02, Kevin O'Connor wrote:
On Fri, Jan 21, 2022 at 03:28:33PM +0100, Alexander Graf wrote:
On 19.01.22 19:45, Kevin O'Connor wrote:
Commit 01f2736cc905d ("nvme: Pass large I/O requests as PRP lists")
introduced multi-page requests using the NVMe PRP mechanism. To store the
list
There is no need to create multiple dma bounce buffers as the BIOS
disk code isn't reentrant capable.
Also, verify that the allocation succeeds.
Signed-off-by: Kevin O'Connor
Reviewed-by: Alexander Graf
---
src/hw/nvme-int.h | 3 ---
src/hw/nvme.c | 21 +++--
2 files
On Fri, Jan 21, 2022 at 11:48:45AM -0500, Kevin O'Connor wrote:
> Rename nvme_build_prpl() to nvme_prpl_xfer() and directly invoke
> nvme_io_xfer() or nvme_bounce_xfer() from that function.
>
> Signed-off-by: Kevin O'Connor
> ---
> src/hw/nvme-int.h | 1 -
> src/hw/nvme.c | 46
On Thu, Jan 13, 2022 at 05:27:11PM +0100, Paul Menzel wrote:
> Dear Kevin,
>
>
> Am 13.01.22 um 17:19 schrieb Kevin O'Connor:
> > Add a hack to suppress spurious gcc array-bounds warning.
>
> Wow, thank you for fixing it. Maybe elaborate a little, what version it
> started with, and reference
This is a resend of the previous series. Changes since last time:
* Patch 1: Fix function comment on nvme_io_xfer()
* Patch 3-5: Added "goto bounce" to nvme_io_xfer() as suggested by Alex
* Patch 6: Added separate "single dma bounce buffer" patch to this series
* Patch 6: Add checking for malloc
On Fri, 21 Jan 2022, Igor Mammedov wrote:
> As for adding ACPI support to xv6, is not so difficult if you only use
> it for detecting CPUs. You only need to locate RSDP which points to
> a list of ACPI tables ((X)RSDT) and then jump and parse MADT table
> which is analog of MP table. It's all
[this is a follow-up email; I took qemu-discuss and qemu-devel off the
distribution list]
On Thu, Jan 20, 2022 at 4:04 AM Igor Mammedov wrote:
>
> Legacy MP table is not actively maintained part of the code,
> hence it's configuration which is not tested.
> However if someone is interested in
28 matches
Mail list logo
