Re: [SeaBIOS] [PATCH v2 2/4] ahci: enable io/mem/dma

2010-12-10 Thread Gerd Hoffmann
Hi, +u16 cmd; You have an unused variable here. Ah, right. Howcome gcc didn't warn me on this, usually it does ... Is that warning turned off for seabios? The patch series looks fine to me. If there's no further comments I'll commit this weekend. Want me respin? Do do you just

Re: [SeaBIOS] seabios: acpi: add _RMV control method for PCI devices

2010-12-10 Thread Avi Kivity
On 12/08/2010 07:08 PM, Marcelo Tosatti wrote: Use _RMV method to indicate whether device can be removed. Data is retrieved from QEMU via I/O port 0xae0c. Where did this port come from? What's the protocol? Maybe we should do this via fw_cfg. -- I have a truly marvellous patch that fixes