Re: [SeaBIOS] [seabios][PATCH 2/2] acpi: change numa data format from fw_cfg interface

2013-02-06 Thread Kevin O'Connor
On Mon, Feb 04, 2013 at 10:28:00AM +0800, liguang wrote: > the old numa format got form fw_cfg is: > number of nodes > node id of cpu (array) > node memory size (array) > > now, format it like array of: > apci_map, > memory_size, > > it has the advantage of simple and clear. With this change, wi

Re: [SeaBIOS] [PATCH v1] Reformat .lst in case it is generated by latest iasl.

2013-02-06 Thread Kevin O'Connor
On Mon, Feb 04, 2013 at 02:06:23PM +0800, Bo Yang wrote: > Latest iasl generate .lst as 'number: ' instead of 'number', then > acpi_extrace.py fails to extract any useful information, building > fails. Thanks. What version of the IASL compiler do you see this issue on? Can you provide a text

Re: [SeaBIOS] [seabios][PATCH 1/2] move all acpi-table related definitions to acpi.h

2013-02-06 Thread Kevin O'Connor
On Mon, Feb 04, 2013 at 10:27:59AM +0800, liguang wrote: > Signed-off-by: liguang Thanks. Some comments. [...] > --- a/src/acpi.h > +++ b/src/acpi.h [...] > +#include "acpi-dsdt.hex" Moving the acpi structure defines to the header is fine, but moving the DSDT code into the header is definitely

Re: [SeaBIOS] [PATCH v2 00/19] SeaBIOS as Compatibility Support Module for UEFI/OVMF

2013-02-06 Thread Kevin O'Connor
On Wed, Feb 06, 2013 at 04:53:29PM +, David Woodhouse wrote: > On Tue, 2013-02-05 at 23:14 -0500, Kevin O'Connor wrote: > > I think the reloc_init() change that I wrote (patch 1) may have been a > > mistake because of the VISIBLE32INIT proliferation that it causes. I > > put together an altern

Re: [SeaBIOS] [PATCH v2 00/19] SeaBIOS as Compatibility Support Module for UEFI/OVMF

2013-02-06 Thread Laszlo Ersek
On 02/06/13 12:06, David Woodhouse wrote: > On Tue, 2013-02-05 at 23:14 -0500, Kevin O'Connor wrote: >> I still need to get an OVMF environment up to test this - I'll do >> that tomorrow. (Sorry for not having yet begun the review, working on other stuff... But certainly don't wait for my review

Re: [SeaBIOS] [PATCH v2 00/19] SeaBIOS as Compatibility Support Module for UEFI/OVMF

2013-02-06 Thread David Woodhouse
On Tue, 2013-02-05 at 23:14 -0500, Kevin O'Connor wrote: > I think the reloc_init() change that I wrote (patch 1) may have been a > mistake because of the VISIBLE32INIT proliferation that it causes. I > put together an alternate approach which requires csm_return(). Hm, there is strangeness here.

Re: [SeaBIOS] [PATCH v2 00/19] SeaBIOS as Compatibility Support Module for UEFI/OVMF

2013-02-06 Thread David Woodhouse
On Tue, 2013-02-05 at 23:14 -0500, Kevin O'Connor wrote: > I still need to get an OVMF environment up to test this - I'll do > that tomorrow. Should go something like this... git clone git://git.infradead.org/users/dwmw2/edk2.git cd edk2 make -C BaseTools . edksetup.sh ln -sf /where/your/seabio