Re: [SeaBIOS] [Qemu-devel] [PATCH v3 5/5] docs: update documentation considering PCIE-PCI bridge

2017-08-01 Thread Laszlo Ersek
On 08/01/17 23:39, Michael S. Tsirkin wrote: > On Wed, Aug 02, 2017 at 12:33:12AM +0300, Alexander Bezzubikov wrote: >> 2017-08-01 23:31 GMT+03:00 Laszlo Ersek : >>> (Whenever my comments conflict with Michael's or Marcel's, I defer to them.) >>> >>> On 07/29/17 01:37, Aleksandr

Re: [SeaBIOS] [Qemu-devel] [PATCH v3 5/5] docs: update documentation considering PCIE-PCI bridge

2017-08-01 Thread Michael S. Tsirkin
On Wed, Aug 02, 2017 at 12:33:12AM +0300, Alexander Bezzubikov wrote: > 2017-08-01 23:31 GMT+03:00 Laszlo Ersek : > > (Whenever my comments conflict with Michael's or Marcel's, I defer to them.) > > > > On 07/29/17 01:37, Aleksandr Bezzubikov wrote: > >> Signed-off-by: Aleksandr

Re: [SeaBIOS] [Qemu-devel] [PATCH v3 5/5] docs: update documentation considering PCIE-PCI bridge

2017-08-01 Thread Alexander Bezzubikov
2017-08-01 23:31 GMT+03:00 Laszlo Ersek : > (Whenever my comments conflict with Michael's or Marcel's, I defer to them.) > > On 07/29/17 01:37, Aleksandr Bezzubikov wrote: >> Signed-off-by: Aleksandr Bezzubikov >> --- >> docs/pcie.txt| 46

Re: [SeaBIOS] [Qemu-devel] [PATCH v3 5/5] docs: update documentation considering PCIE-PCI bridge

2017-08-01 Thread Laszlo Ersek
(Whenever my comments conflict with Michael's or Marcel's, I defer to them.) On 07/29/17 01:37, Aleksandr Bezzubikov wrote: > Signed-off-by: Aleksandr Bezzubikov > --- > docs/pcie.txt| 46 ++ > docs/pcie_pci_bridge.txt | 121 >

Re: [SeaBIOS] [seabios PATCH for qemu 2.10 0/2] seabios: build ACPI 1.0-compatible ACPI tables

2017-08-01 Thread Michael S. Tsirkin
On Wed, Jul 26, 2017 at 11:42:33AM +0200, Paolo Bonzini wrote: > Old operating systems would like to have a rev1 (ACPI 1.0) FADT, but > new operating systems would like to have rev3 (ACPI 2.0). > Since old operating systems do not know about XSDTs, the > solution is to point the RSDT to a v1 FADT

Re: [SeaBIOS] [PATCH v3 2/3] pci: add QEMU-specific PCI capability structure

2017-08-01 Thread Alexander Bezzubikov
2017-08-01 16:38 GMT+03:00 Marcel Apfelbaum : > On 31/07/2017 22:01, Alexander Bezzubikov wrote: >> >> 2017-07-31 21:57 GMT+03:00 Michael S. Tsirkin : >>> >>> On Mon, Jul 31, 2017 at 09:54:55PM +0300, Alexander Bezzubikov wrote: 2017-07-31 17:09

Re: [SeaBIOS] [PATCH v3 2/5] hw/pci: introduce pcie-pci-bridge device

2017-08-01 Thread Marcel Apfelbaum
On 01/08/2017 18:51, Michael S. Tsirkin wrote: On Tue, Aug 01, 2017 at 06:45:13PM +0300, Marcel Apfelbaum wrote: On 01/08/2017 18:32, Michael S. Tsirkin wrote: On Mon, Jul 31, 2017 at 09:40:41PM +0300, Alexander Bezzubikov wrote: +typedef struct PCIEPCIBridge { +/*< private >*/ +

Re: [SeaBIOS] [PATCH v3 2/5] hw/pci: introduce pcie-pci-bridge device

2017-08-01 Thread Michael S. Tsirkin
On Tue, Aug 01, 2017 at 06:45:13PM +0300, Marcel Apfelbaum wrote: > On 01/08/2017 18:32, Michael S. Tsirkin wrote: > > On Mon, Jul 31, 2017 at 09:40:41PM +0300, Alexander Bezzubikov wrote: > > > > > +typedef struct PCIEPCIBridge { > > > > > +/*< private >*/ > > > > > +PCIBridge parent_obj;

Re: [SeaBIOS] [PATCH v3 2/5] hw/pci: introduce pcie-pci-bridge device

2017-08-01 Thread Marcel Apfelbaum
On 01/08/2017 18:32, Michael S. Tsirkin wrote: On Mon, Jul 31, 2017 at 09:40:41PM +0300, Alexander Bezzubikov wrote: +typedef struct PCIEPCIBridge { +/*< private >*/ +PCIBridge parent_obj; + +bool msi_enable; Please rename the msi_enable property to "msi" in order to be aligned

Re: [SeaBIOS] [PATCH v3 2/5] hw/pci: introduce pcie-pci-bridge device

2017-08-01 Thread Michael S. Tsirkin
On Mon, Jul 31, 2017 at 09:40:41PM +0300, Alexander Bezzubikov wrote: > >> +typedef struct PCIEPCIBridge { > >> +/*< private >*/ > >> +PCIBridge parent_obj; > >> + > >> +bool msi_enable; > > > > > > Please rename the msi_enable property to "msi" in order > > to be aligned with the

Re: [SeaBIOS] [PATCH v3 2/3] pci: add QEMU-specific PCI capability structure

2017-08-01 Thread Marcel Apfelbaum
On 31/07/2017 22:01, Alexander Bezzubikov wrote: 2017-07-31 21:57 GMT+03:00 Michael S. Tsirkin : On Mon, Jul 31, 2017 at 09:54:55PM +0300, Alexander Bezzubikov wrote: 2017-07-31 17:09 GMT+03:00 Marcel Apfelbaum : On 31/07/2017 17:00, Michael S. Tsirkin